gh-119698: fix a special case in symtable.Class.get_methods
#121802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, I deprecated the method but kept the fix (I can also revert all the fixes and just mark it as deprecated, but I think it's better to keep something that is working even though we are deprecating it) |
|
I forgot that we backported the original fix... Thanks Serhiy, it should definitely be split into two! |
serhiy-storchaka
approved these changes
Jul 17, 2024
|
(FTR, the last commit is just about reverting some RST content that will be included in the next PR (Serhiy approved the changes at the same time I pushed the commit)) |
picnixz
added
needs backport to 3.12
|
Thanks @picnixz for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 17, 2024
…ythonGH-121802) (cherry picked from commit 6682d91) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 17, 2024
…ythonGH-121802) (cherry picked from commit 6682d91) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-121909 is a backport of this pull request to the 3.13 branch. |
|
GH-121910 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @JelleZijlstra @serhiy-storchaka
So, this is the fix of the fix for the following bug: #119698 (comment)
While this fixes what I did, I'm less and less convinced about keeping the method as well...
Well.. it indeed becomes more and more complex =/ the tests are not really complex but we need a lot of them just to be sure that we cover the cases. Maintenance cost is not that much for me, unless the symtable changes. However, I agree that usefulness is questionable... (still didn't manage to find concrete use cases =/)