Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119698: deprecate symtable.Class.get_methods #121902

Merged
merged 11 commits into from
Jul 22, 2024

Conversation

picnixz
Copy link
Contributor

@picnixz picnixz commented Jul 17, 2024

Deprecation notice for symtable.Class.get_methods for 3.14+ (to be merged after #121802 since it is included in this PR).


📚 Documentation preview 📚: https://cpython-previews--121902.org.readthedocs.build/

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not too sure about the import warnings in the method body instead of at the module level. I'll let a core dev decide on that.

@picnixz
Copy link
Contributor Author

picnixz commented Jul 22, 2024

Friendly ping @JelleZijlstra in case you forgot about this one (or maybe if you were not aware of it).

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, hadn't seen this PR.

@JelleZijlstra JelleZijlstra merged commit c09d4c4 into python:main Jul 22, 2024
37 of 38 checks passed
@picnixz picnixz deleted the deprecate-get-methods-again branch July 22, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants