-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-119698: deprecate symtable.Class.get_methods
#121902
gh-119698: deprecate symtable.Class.get_methods
#121902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not too sure about the import warnings
in the method body instead of at the module level. I'll let a core dev decide on that.
Friendly ping @JelleZijlstra in case you forgot about this one (or maybe if you were not aware of it). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, hadn't seen this PR.
Deprecation notice for
symtable.Class.get_methods
for 3.14+ (to be merged after #121802 since it is included in this PR).📚 Documentation preview 📚: https://cpython-previews--121902.org.readthedocs.build/