gh-108219: Add credits to free-threading project #123802

corona10 · 2024-09-07T02:06:16Z

Issue: PEP 703 -- Making the Global Interpreter Lock Optional in CPython #108219

📚 Documentation preview 📚: https://cpython-previews--123802.org.readthedocs.build/

willingc · 2024-09-07T17:49:29Z

Doc/whatsnew/3.13.rst

@@ -354,6 +354,10 @@ disabled with the :envvar:`PYTHON_GIL` environment variable or the
 pip 24.1 or newer is required to install packages with C extensions in the
 free-threaded build.

+This project has been contributed by many people and the community,
+including Brett Simmers, Dino Viehland, Donghee Na, Ken Jin, Matt Page, and Sam Gross.


Should this include @iritkatriel and a few others from Microsoft too?

No, not me.

Please let me know if I miss someone at Microsoft team.
cc @Fidget-Spinner

Not sure about this, I think there are too many contributors to try listing them exhaustively. Maybe go with something like "Sam Gross and many others"?

Disclaimer: As the person listed in the description, I am biased, so I have no opinions about it.

But listing people as possible can give motivation to work projects not only for this but also other projects. For the faster-cpython project, they listed as many people as possible, so it was a great honor for me, and it motivated me to participate in other projects.
(And It can also be a good reference for persuading a company to let people work part-time on the CPython project.)

"Sam Gross and many others"?

I think this is the minimum option that should be used if there is controversy regarding this.

And I also think there should be more people on the list. Please let me know or have the person update the description with more details.
(I just picked people with free-threading labels)

I can't speak for the MS team because I'm also not employed by them :) but IMO/IIUC the MS team is focused on single-threaded JIT performance mostly. So they werent much involved in the 3.13 free threaded effort, apart from discussions and design help we received from them, which I'm thankful for.

AA-Turner · 2024-09-08T03:31:25Z

Doc/whatsnew/3.13.rst

+This project has been contributed by many people and the community,
+including Brett Simmers, Dino Viehland, Donghee Na, Itamar Oren, Ken Jin,
+Matt Page, and Sam Gross.
+Meta has supported in the form of many engineer-years to this project.


Wording suggestions (on mobile so I can't easily check line wrapping)

Suggested change

This project has been contributed by many people and the community,

including Brett Simmers, Dino Viehland, Donghee Na, Itamar Oren, Ken Jin,

Matt Page, and Sam Gross.

Meta has supported in the form of many engineer-years to this project.

This work is thanks to many people and organisations, including the large community of contributors

to Python and third party projects to test and enable free-threading support.

This includes, but is not limited to:

Sam Gross, Ken Jin, Donghee Na, Itamar Oren, Matt Page, Brett Simmers, and Dino Viehland.

Many of these contributors are employed by Meta Inc,

which has provided significant manpower to support this project.

Thanks, it's more better, and @itamaro is going to add more detail by next week :)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Doc/whatsnew/3.13.rst

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

Doc/whatsnew/3.13.rst

Co-authored-by: Itamar Oren <itamarost@gmail.com>

willingc

@corona10 Thanks for making the effort to be inclusive with the credits after my initial comment. Looks good to me now.

miss-islington-app · 2024-09-08T20:20:19Z

Thanks @corona10 for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

pythonGH-123802) (cherry picked from commit aa3f11f) Co-authored-by: Donghee Na <donghee.na@python.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Itamar Oren <itamarost@gmail.com>

bedevere-app · 2024-09-08T20:20:27Z

GH-123847 is a backport of this pull request to the 3.13 branch.

…ew (GH-123802) (#123847) gh-108219: Add credits to the free-threading entry in What's New (GH-123802) (cherry picked from commit aa3f11f) Co-authored-by: Donghee Na <donghee.na@python.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Itamar Oren <itamarost@gmail.com>

pythongh-108219: Add credits to free-threading project

8dade83

corona10 requested review from colesbury, hugovk and Yhg1s September 7, 2024 02:06

bedevere-app bot added the awaiting core review label Sep 7, 2024

corona10 added skip news and removed awaiting core review labels Sep 7, 2024

bedevere-app bot added the docs Documentation in the Doc dir label Sep 7, 2024

corona10 added needs backport to 3.13 bugs and security fixes and removed docs Documentation in the Doc dir labels Sep 7, 2024

corona10 added 2 commits September 7, 2024 11:19

nit

c577402

fix

fe2f028

willingc reviewed Sep 7, 2024

View reviewed changes

Itamar Oren should be listed for the infrastructure

c45cdfb

AA-Turner reviewed Sep 8, 2024

View reviewed changes

Update Doc/whatsnew/3.13.rst

9929867

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

AA-Turner approved these changes Sep 8, 2024

View reviewed changes

bedevere-app bot added the awaiting merge label Sep 8, 2024

hugovk reviewed Sep 8, 2024

View reviewed changes

Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved

Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved

Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved

corona10 and others added 2 commits September 8, 2024 19:03

Apply suggestions from code review

d900780

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

Use a gender-neutral term

33be59e

itamaro reviewed Sep 8, 2024

View reviewed changes

Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved

Update Doc/whatsnew/3.13.rst

79ec285

Co-authored-by: Itamar Oren <itamarost@gmail.com>

corona10 requested review from hugovk, AA-Turner and itamaro September 8, 2024 17:02

itamaro approved these changes Sep 8, 2024

View reviewed changes

willingc approved these changes Sep 8, 2024

View reviewed changes

AA-Turner approved these changes Sep 8, 2024

View reviewed changes

AA-Turner merged commit aa3f11f into python:main Sep 8, 2024
23 checks passed

bedevere-app bot removed the awaiting merge label Sep 8, 2024

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 8, 2024

corona10 deleted the gh-108219-authors branch September 9, 2024 01:07

kumaraditya303 mentioned this pull request Nov 16, 2024

PEP 703 -- Making the Global Interpreter Lock Optional in CPython #108219

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-108219: Add credits to free-threading project #123802

gh-108219: Add credits to free-threading project #123802

corona10 commented Sep 7, 2024 •

edited by github-actions bot

Loading

willingc Sep 7, 2024

iritkatriel Sep 7, 2024

corona10 Sep 7, 2024 •

edited

Loading

itamaro Sep 8, 2024

corona10 Sep 8, 2024 •

edited

Loading

corona10 Sep 8, 2024

Fidget-Spinner Sep 8, 2024 •

edited

Loading

AA-Turner Sep 8, 2024 •

edited

Loading

corona10 Sep 8, 2024

willingc left a comment

miss-islington-app bot commented Sep 8, 2024

bedevere-app bot commented Sep 8, 2024

-This project has been contributed by many people and the community,
-including Brett Simmers, Dino Viehland, Donghee Na, Itamar Oren, Ken Jin,
-Matt Page, and Sam Gross.
-Meta has supported in the form of many engineer-years to this project.
+This work is thanks to many people and organisations, including the large community of contributors
+to Python and third party projects to test and enable free-threading support.
+This includes, but is not limited to:
+Sam Gross, Ken Jin, Donghee Na, Itamar Oren, Matt Page, Brett Simmers, and Dino Viehland.
+Many of these contributors are employed by Meta Inc,
+which has provided significant manpower to support this project.

gh-108219: Add credits to free-threading project #123802

gh-108219: Add credits to free-threading project #123802

Conversation

corona10 commented Sep 7, 2024 • edited by github-actions bot Loading

willingc Sep 7, 2024

Choose a reason for hiding this comment

iritkatriel Sep 7, 2024

Choose a reason for hiding this comment

corona10 Sep 7, 2024 • edited Loading

Choose a reason for hiding this comment

itamaro Sep 8, 2024

Choose a reason for hiding this comment

corona10 Sep 8, 2024 • edited Loading

Choose a reason for hiding this comment

corona10 Sep 8, 2024

Choose a reason for hiding this comment

Fidget-Spinner Sep 8, 2024 • edited Loading

Choose a reason for hiding this comment

AA-Turner Sep 8, 2024 • edited Loading

Choose a reason for hiding this comment

corona10 Sep 8, 2024

Choose a reason for hiding this comment

willingc left a comment

Choose a reason for hiding this comment

miss-islington-app bot commented Sep 8, 2024

bedevere-app bot commented Sep 8, 2024

corona10 commented Sep 7, 2024 •

edited by github-actions bot

Loading

corona10 Sep 7, 2024 •

edited

Loading

corona10 Sep 8, 2024 •

edited

Loading

Fidget-Spinner Sep 8, 2024 •

edited

Loading

AA-Turner Sep 8, 2024 •

edited

Loading