Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-108219: Add credits to free-threading project #123802

Merged
merged 8 commits into from
Sep 8, 2024
Merged

gh-108219: Add credits to free-threading project #123802

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8dade83
gh-108219: Add credits to free-threading project
corona10 Sep 7, 2024
c577402
nit
corona10 Sep 7, 2024
fe2f028
fix
corona10 Sep 7, 2024
c45cdfb
Itamar Oren should be listed for the infrastructure
corona10 Sep 8, 2024
9929867
Update Doc/whatsnew/3.13.rst
corona10 Sep 8, 2024
d900780
Apply suggestions from code review
corona10 Sep 8, 2024
33be59e
Use a gender-neutral term
corona10 Sep 8, 2024
79ec285
Update Doc/whatsnew/3.13.rst
corona10 Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Doc/whatsnew/3.13.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,10 @@ disabled with the :envvar:`PYTHON_GIL` environment variable or the
pip 24.1 or newer is required to install packages with C extensions in the
free-threaded build.

This project has been contributed by many people and the community,
including Brett Simmers, Dino Viehland, Donghee Na, Ken Jin, Matt Page, and Sam Gross.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include @iritkatriel and a few others from Microsoft too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not me.

Copy link
Member Author

@corona10 corona10 Sep 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if I miss someone at Microsoft team.
cc @Fidget-Spinner

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this, I think there are too many contributors to try listing them exhaustively. Maybe go with something like "Sam Gross and many others"?

Copy link
Member Author

@corona10 corona10 Sep 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: As the person listed in the description, I am biased, so I have no opinions about it.

But listing people as possible can give motivation to work projects not only for this but also other projects. For the faster-cpython project, they listed as many people as possible, so it was a great honor for me, and it motivated me to participate in other projects.
(And It can also be a good reference for persuading a company to let people work part-time on the CPython project.)

"Sam Gross and many others"?

I think this is the minimum option that should be used if there is controversy regarding this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I also think there should be more people on the list. Please let me know or have the person update the description with more details.
(I just picked people with free-threading labels)

Copy link
Member

@Fidget-Spinner Fidget-Spinner Sep 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for the MS team because I'm also not employed by them :) but IMO/IIUC the MS team is focused on single-threaded JIT performance mostly. So they werent much involved in the 3.13 free threaded effort, apart from discussions and design help we received from them, which I'm thankful for.

Meta has supported in the form of many engineer-years to this project.

.. seealso::

:pep:`703` "Making the Global Interpreter Lock Optional in CPython"
Expand Down
Loading