-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36889: Merge asyncio streams #13251
Conversation
The main part is basically done. The functionality is test covered for all significant code paths because the PR doesn't change too much but "just" merges StreamReader and StreamWriter. There are two options for future steps:
The wish list is:
|
@@ -0,0 +1,2 @@ | |||
Merge asyncio.StreamReader and asyncio.StreamWriter into asyncio.Stream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please enumerate all new APIs in this NEWS entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to address my comments prior to merging. Great work, Andrew!
Reverts changes made in 3.8 to asyncio streams (23b4b69).
This reverts commit 23b4b69.
https://bugs.python.org/issue36889