bpo-38242: Revert "bpo-36889: Merge asyncio streams (GH-13251)"

[1st1]

See https://bugs.python.org/issue38242 for more details

99% of the work is done by @aeros167; I've just needed to add a few more fixes and couldn't push to his branch; hence the new PR.

https://bugs.python.org/issue38242

[aeros]

99% of the work is done by @aeros167; I've just needed to add a few more fixes and couldn't push to his branch; hence the new PR.

Thanks for finishing this up Yury. Out of curiosity, what additional changes needed to be made?

[1st1]

Thanks for finishing this up Yury. Out of curiosity, what additional changes needed to be made?

.write() and .close() were still awaitable -- which technically was committed before new streams api. Still we want to revert streams to their 3.7 state.

[aeros]

The constant _DEFAULT_LIMIT (2**16) is still being used as the default for limit in start_server(), so this can be restored.

Suggested change

	port=None, \*, loop=None, limit=None, \
	port=None, \*, loop=None, limit=2**16, \

[aeros]

I can do this in a separate PR if needed. This change is rather low priority in comparison to reverting the streaming API, and would not be a release blocker.

[1st1]

Sure, although right now docs are the same as in 3.7. So I'm not sure it's needed tbh.

[aeros]

So I'm not sure it's needed tbh.

Okay, I won't worry about it then, it's fairly trivial.

[aeros]

.write() and .close() were still awaitable -- which technically was committed before new streams api. Still we want to revert streams to their 3.7 state.

Ah, I wasn't aware we were also removing that change. I hadn't realized we were reverting fully back to the 3.7 API, I thought it was primarily just focused on 23b4b69. Now it makes a lot more sense why you wanted to remove _asyncio_internal.

[bedevere-bot]

@1st1: Please replace # with GH- in the commit message next time. Thanks!

[miss-islington]

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

[miss-islington]

Sorry, @1st1, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6758e6e12a71ef5530146161881f88df1fa43382 3.8

[bedevere-bot]

GH-16485 is a backport of this pull request to the 3.8 branch.