-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-24464: Deprecate sqlite3.enable_shared_cache #24008
bpo-24464: Deprecate sqlite3.enable_shared_cache #24008
Conversation
FYI https://sqlite.org/c3ref/enable_shared_cache.html: |
Doc/whatsnew/3.10.rst
Outdated
@@ -462,6 +462,14 @@ Deprecated | |||
scheduled for removal in Python 3.12. | |||
(Contributed by Erlend E. Aasland in :issue:`42264`.) | |||
|
|||
* ``sqlite3.enable_shared_cache`` is now deprecated, scheduled for removal in | |||
Python 3.12. The method is undocumented, and it's use is strongly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 3.12. The method is undocumented, and it's use is strongly | |
Python 3.12. The method is undocumented, and its use is strongly |
It is incorrect to use a contraction here.
Also, it seems that sqlite3.enable_shared_cache
is not a method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it seems that
sqlite3.enable_shared_cache
is not a method.
Correct, it's a built-in function. Good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 7d52671. Is the new phrasing acceptable?
Misc/NEWS.d/next/Library/2020-12-30-14-56-25.bpo-24464.vbNVHe.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2020-12-30-14-56-25.bpo-24464.vbNVHe.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
PTAL, @ZackerySpytz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks, and thanks for the markup fix, @berkerpeksag ! |
All failed tests seem to be unrelated and flaky. Will continue with merge. |
The following sqlite3 features were deprecated in 3.10, scheduled for removal in 3.12: - sqlite3.OptimizedUnicode (pythongh-23163) - sqlite3.enable_shared_cache (pythongh-24008) Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
https://bugs.python.org/issue24464