Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92547: Remove deprecated sqlite3 features #92548

Merged
merged 5 commits into from
May 16, 2022
Merged

gh-92547: Remove deprecated sqlite3 features #92548

merged 5 commits into from
May 16, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 9, 2022 •
edited
Loading

The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com

Closes #92547

@erlend-aasland
gh-92547: Remove deprecated sqlite3 features
8312697 
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

- sqlite3.OptimizedUnicode (gh-23163)
- sqlite3.enable_shared_cache (gh-24008)

Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
JelleZijlstra
JelleZijlstra approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but let's hold off on merging until the nltk usage of OptimizedUnicode is fixed.

@erlend-aasland
Copy link
Contributor Author

Code looks good, but let's hold off on merging until the nltk usage of OptimizedUnicode is fixed.

FTR, nltk/nltk#3000 was just merged.

@JelleZijlstra
Copy link
Member

Feel free to merge!

@erlend-aasland erlend-aasland merged commit 00f22e8 into main May 16, 2022
@erlend-aasland erlend-aasland deleted the sqlite-remove-deprecated-features branch May 16, 2022 17:52
@erlend-aasland
Copy link
Contributor Author

Thanks for helping, Jelle and Victor!

@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
@vstinner
Copy link
Member

Removed code contained instructions to port existing code to avoid the deprecation warning: replace OptimizedUnicode with str and use URI with cache=shared: 00f22e8

Would you mind to copy these information in What's New in Python 3.12?

@erlend-aasland
Copy link
Contributor Author

Removed code contained instructions to port existing code to avoid the deprecation warning: replace OptimizedUnicode with str and use URI with cache=shared: 00f22e8

Would you mind to copy these information in What's New in Python 3.12?

Yes, I'll amend What's New. Thanks for the heads-up!

@erlend-aasland
Copy link
Contributor Author

Would you mind to copy these information in What's New in Python 3.12?

Something like this? #93872

@vstinner
Copy link
Member

Something like this? #93872

That's very valuable, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3: remove features deprecated in 3.10
4 participants
@erlend-aasland @JelleZijlstra @vstinner @bedevere-bot