Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite #26542

Merged
merged 2 commits into from
Jun 4, 2021
Merged

bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite #26542

merged 2 commits into from
Jun 4, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 4, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested review from 1st1 and asvetlov as code owners June 4, 2021 22:49
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 4, 2021
@pablogsal pablogsal mentioned this pull request Jun 4, 2021
Closed
@pablogsal pablogsal requested a review from cjerdonek June 4, 2021 22:50
@pablogsal
Copy link
Member Author

@cjerdonek could you take a look?

@pablogsal pablogsal added skip news needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jun 4, 2021
cjerdonek
cjerdonek approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@cjerdonek cjerdonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that looks fine.

@pablogsal pablogsal merged commit f171877 into python:main Jun 4, 2021
@pablogsal pablogsal deleted the bpo-38323 branch June 4, 2021 23:33
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @pablogsal, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f171877ebe276749f31386baed5841ce37cbee2e 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2021
@pablogsal @miss-islington
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
c48ccc3 
…est suite (pythonGH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-26543 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 4, 2021
@pablogsal pablogsal added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Jun 4, 2021
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 4, 2021
@bedevere-bot
Copy link

GH-26544 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2021
@pablogsal @miss-islington
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
ff6097c 
…est suite (pythonGH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Jun 5, 2021
@miss-islington @pablogsal
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
b3c50b2 
…est suite (GH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jun 5, 2021
@miss-islington @pablogsal
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
0d441d2 
…est suite (GH-26542) (GH-26544)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@vstinner
Copy link
Member

vstinner commented Jun 7, 2021 •
edited by bedevere-bot
Loading 

 @unittest.skip("[bpo-38323](https://bugs.python.org/issue38323): MultiLoopChildWatcher has a race condition

FYI if a skip message contains "bpo-xxx", a buildbot fails when a PR is merged and the buildbot logs contain the skip message, the PR will be attached to bpo-xxx.

IMO the bot attaching PRs to bpo issues should only look into the PR title, not in PR comments.

@pablogsal
Copy link
Member Author

FYI if a skip message contains "bpo-xxx", a buildbot fails when a PR is merged and the buildbot logs contain the skip message, the PR will be attached to bpo-xxx.

Well, hopefully soon we can merge some form of your PR and then remove that skip :)

@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-26670 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2021
@pablogsal @miss-islington
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
5c750ad 
…est suite (pythonGH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jun 12, 2021
@miss-islington @pablogsal
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
af5fb67 
…est suite (GH-26542) (GH-26670)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
@kumaraditya303 kumaraditya303 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjerdonek cjerdonek cjerdonek approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

@pablogsal pablogsal

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pablogsal @miss-islington @bedevere-bot @vstinner @cjerdonek @the-knights-who-say-ni