Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-82504: deprecate the MultiLoopChildWatcher #94648

Closed
wants to merge 16 commits into from
Closed

gh-82504: deprecate the MultiLoopChildWatcher #94648

wants to merge 16 commits into from

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Jul 7, 2022 •
edited by bedevere-bot
Loading

@graingert graingert changed the title bpo-82504: deprecate the MultiLoopChildWatcher gh-82504: deprecate the MultiLoopChildWatcher Jul 7, 2022
@graingert graingert mentioned this pull request Jul 7, 2022
Closed
@graingert graingert marked this pull request as ready for review July 7, 2022 09:18
@graingert graingert requested review from 1st1 and asvetlov as code owners July 7, 2022 09:18
kumaraditya303
kumaraditya303 requested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to add What's New entry about this deprecation.

@graingert @kumaraditya303
Update Misc/NEWS.d/next/Library/2022-07-07-09-04-49.gh-issue-82504.6x…
ae826fa 
…tYAz.rst

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
graingert
graingert commented Jul 18, 2022
View reviewed changes
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
@graingert graingert force-pushed the deprecate-multi-loop-watcher branch from 84a0ca0 to 2e6e996 Compare July 18, 2022 16:20
@graingert graingert requested a review from kumaraditya303 July 18, 2022 16:21
kumaraditya303
kumaraditya303 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graingert
Copy link
Contributor Author

thanks for the review @kumaraditya303 !

@kumaraditya303
Copy link
Contributor

@gvanrossum Would you like to review this? This deprecates MultiLoopChildWatcher which has race conditions so it is not even tested on CI currently, skipped on CI as of #26542.

@gvanrossum
Copy link
Member

I'm sorry, I don't feel comfortable reviewing this. Any core dev CC'ed on the issue would be more qualified than me.

@gvanrossum gvanrossum removed their request for review July 18, 2022 23:12
@graingert
Copy link
Contributor Author

@kumaraditya303 can you request @njsmith on this?

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Oct 9, 2022 •
edited
Loading

Superseded by #98089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@njsmith njsmith Awaiting requested review from njsmith

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@graingert @kumaraditya303 @gvanrossum @AlexWaygood @bedevere-bot