Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466) #29466

Merged
merged 8 commits into from
Nov 8, 2021
Merged

bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466) #29466

merged 8 commits into from
Nov 8, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 8, 2021 •
edited
Loading

  • Add PY_CHECK_CC_WARNING helper
  • Normalise variable name: ac_cv_[enable|disable]_[flag_name]_warning; for example ac_cv_disable_unused_result_warning
  • Use AS_IF to check results and add flags

No new cache vars added, so there is no speedups; only simplified ac code.

Bonus: fixed a misspelling bug (see ac_cv_enable_enable_strict_prototypes_warning)

https://bugs.python.org/issue45723

@erlend-aasland
Copy link
Contributor Author

cc. @tiran

tiran
tiran reviewed Nov 8, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland marked this pull request as ready for review November 8, 2021 10:47
@erlend-aasland erlend-aasland requested a review from tiran November 8, 2021 10:47
tiran
tiran reviewed Nov 8, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
Address review
304f780 
- Use AS_VAR_IF() a couple of more times
- Use CFLAGS iso. CC when overriding compiler flags
@erlend-aasland erlend-aasland requested a review from tiran November 8, 2021 12:03
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @tiran for commit 304f780 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 8, 2021
@erlend-aasland
Copy link
Contributor Author

Do you want a NEWS item for this, @tiran?

tiran
tiran approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@erlend-aasland
Copy link
Contributor Author

Thanks for reviewing!

@tiran tiran changed the title bpo-45723: Add macro for disabling/enabling CC warnings bpo-45723: Add macro for disabling/enabling CC warnings (GH-29466) Nov 8, 2021
@tiran tiran merged commit 9bd0cf5 into python:main Nov 8, 2021
@erlend-aasland erlend-aasland deleted the ac-cc-flags branch November 8, 2021 17:59
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran @remykarem
bpo-45723: Add macro for disabling/enabling CC warnings (pythonGH-29466)
778b147 
Co-authored-by: Christian Heimes <christian@python.org>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@tiran @remykarem
bpo-45723: Add macro for disabling/enabling CC warnings (pythonGH-29466)
29514b3 
Co-authored-by: Christian Heimes <christian@python.org>
@tiran tiran mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @bedevere-bot @tiran @the-knights-who-say-ni