Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45723: Improve and simplify more configure.ac checks (GH-29485) #29485

Merged
merged 6 commits into from
Nov 10, 2021
Merged

bpo-45723: Improve and simplify more configure.ac checks (GH-29485) #29485

merged 6 commits into from
Nov 10, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 9, 2021 •
edited by bedevere-bot
Loading

  • Cache checking of -Wl,--no-as-needed
  • Make PY_CHECK_CC_WARNING more efficient
  • Consolidate AC_MSG_CHECKING and AC_CACHE_VAL

https://bugs.python.org/issue45723

@erlend-aasland erlend-aasland requested a review from tiran November 9, 2021 12:49
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 9, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 79b97e0 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 9, 2021
tiran
tiran approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll do another test before I merge the PR.

@erlend-aasland
Copy link
Contributor Author

Looks good to me. I'll do another test before I merge the PR.

Great, thanks!

@tiran tiran changed the title bpo-45723: Improve and simplify more configure.ac checks bpo-45723: Improve and simplify more configure.ac checks (GH-29485) Nov 10, 2021
@tiran tiran merged commit 76d14fa into python:main Nov 10, 2021
@erlend-aasland erlend-aasland deleted the ac-more-stuff branch November 10, 2021 15:44
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@remykarem
bpo-45723: Improve and simplify more configure.ac checks (pythonGH-29485
669fb41 
)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@remykarem
bpo-45723: Improve and simplify more configure.ac checks (pythonGH-29485
c4ffd3c 
)
@tiran tiran mentioned this pull request Apr 22, 2022
Closed
@virtuald virtuald mentioned this pull request Oct 14, 2022
Merged
@eli-schwartz eli-schwartz mentioned this pull request Jun 19, 2024
Closed
@allsey87 allsey87 mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @bedevere-bot @tiran @the-knights-who-say-ni