Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45723: Remove dead code for obsolete --with-dyld option #29500

Merged
merged 2 commits into from
Nov 9, 2021
Merged

bpo-45723: Remove dead code for obsolete --with-dyld option #29500

merged 2 commits into from
Nov 9, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 9, 2021 •
edited by miss-islington
Loading

Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"

https://bugs.python.org/issue45723

Automerge-Triggered-By: GH:tiran

bpo-45723: Remove dead code for obsolete --with-dyld option
b62f459 
Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"
@erlend-aasland erlend-aasland requested a review from tiran November 9, 2021 19:34
tiran
tiran approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tiran
tiran requested changes Nov 9, 2021
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to regenerate configure, too.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland erlend-aasland requested a review from tiran November 9, 2021 20:42
@erlend-aasland
Copy link
Contributor Author

You need to regenerate configure, too.

Hm, we could add a configure/configure.ac check to the Check if generated files are up to date CI.

@tiran
Copy link
Member

tiran commented Nov 9, 2021

You need to regenerate configure, too.

Hm, we could add a configure/configure.ac check to the Check if generated files are up to date CI.

First I like to move my repo to python org and figure out hosting on ghcr.io.

@miss-islington
Copy link
Contributor

@erlend-aasland: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 49171aa into python:main Nov 9, 2021
@erlend-aasland erlend-aasland deleted the ac-remove-dead-code branch November 9, 2021 21:06
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
@thatbirdguythatuknownot
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
be6e319 
…GH-29500)
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
@thatbirdguythatuknownot
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
30388b9 
…GH-29500)
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
@thatbirdguythatuknownot
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
e937253 
…GH-29500)
thatbirdguythatuknownot added a commit to thatbirdguythatuknownot/cpython that referenced this pull request Nov 9, 2021
@thatbirdguythatuknownot
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
86e565a 
…GH-29500)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@remykarem
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
f892757 
…GH-29500)

Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"

Automerge-Triggered-By: GH:tiran
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@remykarem
bpo-45723: Remove dead code for obsolete --with-dyld option (python…
ba54db9 
…GH-29500)

Was commented out by Jack Jansen in 2001-08-15 by commit
b6e9cad:

"Ripped out Next/OpenStep support, which was broken anyway"

Automerge-Triggered-By: GH:tiran
@tiran tiran mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @bedevere-bot @tiran @miss-islington @the-knights-who-say-ni