-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45582: Fix out-of-tree build issues with new getpath (GH-29902) #29902
Conversation
b7c7f36
to
f86d836
Compare
* Create getpath.h in builddir tree instead of srcdir tree * Move getpath.h to Python/frozen_modules so it gets removed on ``make clean`` and to make it more obvious that it is a frozen file. * Add dependency on header files * Remove target body from getpath_noop.o so it uses the ``.c.o:`` template
f86d836
to
d97c697
Compare
784e107
to
cd85c8f
Compare
@zooba Please take a look |
@tiran Looks fine. Out of interest, which bit fixes the out-of-tree issues? I only see changes moving where the generated file goes (which in my defence, changed three times while I was working on that PR 😆 ) Edit Found it - removing the |
Yes, the getpath.h is no longer in I'm working on CI for OOT builds: #29904 |
|
|
make clean
and to make it more obvious that it is a frozen file..c.o:
template
https://bugs.python.org/issue45582