Internal error with an alias type that is a callable with an unpacked tuple as args #16533

Drache91 · 2023-11-21T11:53:15Z

Bug Report

Mypy crashes (errors) when using an aliased Callable with an unpacked Tuple within the arguments part. The definition throws no errors and using the type without the use of an alias is also working fine.

mypy version: 1.7.0
python version: 3.11.2

To Reproduce

This is the smallest reproduction I could come up with. The error occours with the definition of f2 where the type alias _CallableValue is used.

from typing import Callable, Any, Tuple, Unpack


_CallableValue = Callable[[Unpack[Tuple[Any, ...]]], Any]  # This is fine

def f(fun: Callable[[Unpack[Tuple[Any, ...]]], Any]) -> None: ...  # This is fine

def f2(fun: _CallableValue) -> None: ...  # Mypy errors here with an internal error

(Playground)

Expected Behavior

I would expect mypy to not have an internal error and instead produce a success result.

Actual Behavior

Mypy has an internal error.

Output with my projects environment (VSCode, Python 3.11.2, mypy 1.7.0 (compiled: yes)):

2023-11-21 12:20:06.389 [info] [Trace - 12:20:06 PM] Sending notification 'textDocument/didSave'.
2023-11-21 12:20:06.397 [info] [Trace - 12:20:06 PM] Received notification 'window/logMessage'.
2023-11-21 12:20:06.397 [info] venv/Scripts/python.exe -m mypy --no-color-output --no-error-summary --show-absolute-path --show-column-numbers --show-error-codes --no-pretty --show-traceback --show-error-end c:\Users\[PROJECT_PATH]\.vscode\mypytest.py
2023-11-21 12:20:06.398 [info] [Trace - 12:20:06 PM] Received notification 'window/logMessage'.
2023-11-21 12:20:06.398 [info] CWD Server: c:\Users\[PROJECT_PATH]
2023-11-21 12:20:07.125 [info] [Trace - 12:20:07 PM] Received notification 'window/logMessage'.
2023-11-21 12:20:07.125 [info] c:\Users\[PROJECT_PATH]\.vscode\mypytest.py:7: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 1.7.0
c:\Users\[PROJECT_PATH]\.vscode\mypytest.py:7: : note: use --pdb to drop into pdb

2023-11-21 12:20:07.126 [info] [Trace - 12:20:07 PM] Received notification 'window/logMessage'.
2023-11-21 12:20:07.126 [info] file:///c%3A/Users/[PROJECT_PATH]/.vscode/mypytest.py :
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "mypy\semanal.py", line 6525, in accept
  File "mypy\nodes.py", line 785, in accept
  File "mypy\semanal.py", line 832, in visit_func_def
  File "mypy\semanal.py", line 866, in analyze_func_def
  File "mypy\semanal_shared.py", line 373, in has_placeholder
  File "mypy\types.py", line 1964, in accept
  File "mypy\type_visitor.py", line 505, in visit_callable_type
  File "mypy\type_visitor.py", line 557, in query_types
  File "mypy\types.py", line 395, in accept
  File "mypy\type_visitor.py", line 550, in visit_type_alias_type
  File "mypy\types.py", line 3072, in get_proper_type
  File "mypy\types.py", line 337, in _expand_once
  File "mypy\types.py", line 1964, in accept
  File "mypy\expandtype.py", line 368, in visit_callable_type
  File "mypy\expandtype.py", line 317, in interpolate_args_for_unpack
AssertionError: 

2023-11-21 12:20:07.126 [info] [Trace - 12:20:07 PM] Received notification 'window/logMessage'.
2023-11-21 12:20:07.126 [info] file:///c%3A/Users/[PROJECT_PATH]/.vscode/mypytest.py :
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "mypy\semanal.py", line 6525, in accept
  File "mypy\nodes.py", line 785, in accept
  File "mypy\semanal.py", line 832, in visit_func_def
  File "mypy\semanal.py", line 866, in analyze_func_def
  File "mypy\semanal_shared.py", line 373, in has_placeholder
  File "mypy\types.py", line 1964, in accept
  File "mypy\type_visitor.py", line 505, in visit_callable_type
  File "mypy\type_visitor.py", line 557, in query_types
  File "mypy\types.py", line 395, in accept
  File "mypy\type_visitor.py", line 550, in visit_type_alias_type
  File "mypy\types.py", line 3072, in get_proper_type
  File "mypy\types.py", line 337, in _expand_once
  File "mypy\types.py", line 1964, in accept
  File "mypy\expandtype.py", line 368, in visit_callable_type
  File "mypy\expandtype.py", line 317, in interpolate_args_for_unpack
AssertionError: 

2023-11-21 12:20:07.126 [info] [Trace - 12:20:07 PM] Received notification 'textDocument/publishDiagnostics'.

Playground gist output (Python 3.11 and mypy 1.7.0)

Failed (exit code: 2) (3302 ms)

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "mypy/semanal.py", line 6525, in accept
  File "mypy/nodes.py", line 785, in accept
  File "mypy/semanal.py", line 832, in visit_func_def
  File "mypy/semanal.py", line 866, in analyze_func_def
  File "mypy/semanal_shared.py", line 373, in has_placeholder
  File "mypy/types.py", line 1964, in accept
  File "mypy/type_visitor.py", line 505, in visit_callable_type
  File "mypy/type_visitor.py", line 557, in query_types
  File "mypy/types.py", line 395, in accept
  File "mypy/type_visitor.py", line 550, in visit_type_alias_type
  File "mypy/types.py", line 3072, in get_proper_type
  File "mypy/types.py", line 337, in _expand_once
  File "mypy/types.py", line 1964, in accept
  File "mypy/expandtype.py", line 368, in visit_callable_type
  File "mypy/expandtype.py", line 317, in interpolate_args_for_unpack
AssertionError: 

main.py:8: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 1.7.0
main.py:8: : note: use --pdb to drop into pdb

Your Environment

Mypy version used: 1.7.0 (compiled: yes)
Mypy command-line flags: -no-color-output --no-error-summary --show-absolute-path --show-column-numbers --show-error-codes --no-pretty --show-traceback --show-error-end c:\Users\[PROJECT_PATH]\.vscode\mypytest.py
Mypy configuration options from mypy.ini (and other config files):

[mypy]
plugins = pydantic.mypy
follow_imports = silent
warn_redundant_casts = True
disallow_untyped_defs = True
disallow_any_unimported = False
no_implicit_optional = True
check_untyped_defs = True
warn_return_any = True
show_error_codes = True
warn_unused_ignores = True

Python version used: 3.11.2

(It's reproducable on the mypy playground, please see the "Playground"-link at the bottom of the "To Reproduce"-section.)

The text was updated successfully, but these errors were encountered:

AlexWaygood · 2023-11-22T12:22:20Z

Here's the traceback using uncompiled mypy from the master branch, FWIW:

version: 1.8.0+dev.242ad2ac4dec105fbed37c177d4cff5944a00f1d
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\alexw\coding\mypy\venv\Scripts\mypy.exe\__main__.py", line 7, in <module>
    sys.exit(console_entry())
  File "C:\Users\alexw\coding\mypy\mypy\__main__.py", line 15, in console_entry
    main()
  File "C:\Users\alexw\coding\mypy\mypy\main.py", line 100, in main
    res, messages, blockers = run_build(sources, options, fscache, t0, stdout, stderr)
  File "C:\Users\alexw\coding\mypy\mypy\main.py", line 182, in run_build
    res = build.build(sources, options, None, flush_errors, fscache, stdout, stderr)
  File "C:\Users\alexw\coding\mypy\mypy\build.py", line 191, in build
    result = _build(
  File "C:\Users\alexw\coding\mypy\mypy\build.py", line 265, in _build
    graph = dispatch(sources, manager, stdout)
  File "C:\Users\alexw\coding\mypy\mypy\build.py", line 2943, in dispatch
    process_graph(graph, manager)
  File "C:\Users\alexw\coding\mypy\mypy\build.py", line 3341, in process_graph
    process_stale_scc(graph, scc, manager)
  File "C:\Users\alexw\coding\mypy\mypy\build.py", line 3436, in process_stale_scc
    mypy.semanal_main.semantic_analysis_for_scc(graph, scc, manager.errors)
  File "C:\Users\alexw\coding\mypy\mypy\semanal_main.py", line 94, in semantic_analysis_for_scc
    process_functions(graph, scc, patches)
  File "C:\Users\alexw\coding\mypy\mypy\semanal_main.py", line 252, in process_functions
    process_top_level_function(
  File "C:\Users\alexw\coding\mypy\mypy\semanal_main.py", line 291, in process_top_level_function
    deferred, incomplete, progress = semantic_analyze_target(
  File "C:\Users\alexw\coding\mypy\mypy\semanal_main.py", line 349, in semantic_analyze_target
    analyzer.refresh_partial(
  File "C:\Users\alexw\coding\mypy\mypy\semanal.py", line 600, in refresh_partial
    self.accept(node)
  File "C:\Users\alexw\coding\mypy\mypy\semanal.py", line 6538, in accept
    node.accept(self)
  File "C:\Users\alexw\coding\mypy\mypy\nodes.py", line 787, in accept
    return visitor.visit_func_def(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\semanal.py", line 833, in visit_func_def
    self.analyze_func_def(defn)
  File "C:\Users\alexw\coding\mypy\mypy\semanal.py", line 867, in analyze_func_def
    if self.found_incomplete_ref(tag) or has_placeholder(result):
                                         ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\semanal_shared.py", line 373, in has_placeholder
    return typ.accept(HasPlaceholders())
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\types.py", line 1970, in accept
    return visitor.visit_callable_type(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\type_visitor.py", line 505, in visit_callable_type
    args = self.query_types(t.arg_types)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\type_visitor.py", line 557, in query_types
    return any(t.accept(self) for t in types)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\type_visitor.py", line 557, in <genexpr>
    return any(t.accept(self) for t in types)
               ^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\types.py", line 401, in accept
    return visitor.visit_type_alias_type(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\type_visitor.py", line 550, in visit_type_alias_type
    return get_proper_type(t).accept(self)
           ^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\types.py", line 3078, in get_proper_type
    typ = typ._expand_once()
          ^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\types.py", line 343, in _expand_once
    new_tp = self.alias.target.accept(InstantiateAliasVisitor(mapping))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\types.py", line 1970, in accept
    return visitor.visit_callable_type(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\expandtype.py", line 369, in visit_callable_type
    arg_types = self.interpolate_args_for_unpack(t, var_arg.typ)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\alexw\coding\mypy\mypy\expandtype.py", line 318, in interpolate_args_for_unpack
    assert isinstance(var_arg_type, TypeVarTupleType)
AssertionError:

It looks like var_arg_type is actually a mypy.types.Instance instance.

…]` (#16541) Fixes #16533

Drache91 added the bug mypy got something wrong label Nov 21, 2023

AlexWaygood added crash topic-pep-646 PEP 646 (TypeVarTuple, Unpack) topic-type-alias TypeAlias and other type alias issues and removed bug mypy got something wrong labels Nov 21, 2023

AlexWaygood mentioned this issue Nov 22, 2023

Fix crash with type alias to Callable[[Unpack[Tuple[Any, ...]]], Any] #16541

Merged

JukkaL closed this as completed in #16541 Dec 12, 2023

JukkaL pushed a commit that referenced this issue Dec 12, 2023

Fix crash with type alias to `Callable[[Unpack[Tuple[Any, ...]]], Any…

5fa9569

…]` (#16541) Fixes #16533

wesleywright pushed a commit that referenced this issue Dec 12, 2023

Fix crash with type alias to `Callable[[Unpack[Tuple[Any, ...]]], Any…

60d30e3

…]` (#16541) Fixes #16533

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Internal error with an alias type that is a callable with an unpacked tuple as args #16533

Internal error with an alias type that is a callable with an unpacked tuple as args #16533

Drache91 commented Nov 21, 2023

AlexWaygood commented Nov 22, 2023 •

edited

Loading

Internal error with an alias type that is a callable with an unpacked tuple as args #16533

Internal error with an alias type that is a callable with an unpacked tuple as args #16533

Comments

Drache91 commented Nov 21, 2023

AlexWaygood commented Nov 22, 2023 • edited Loading

AlexWaygood commented Nov 22, 2023 •

edited

Loading