Fix crash with type alias to Callable[[Unpack[Tuple[Any, ...]]], Any]
#16541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Closed
JukkaL
reviewed
Dec 7, 2023
mypy/expandtype.py
Outdated
| expanded_tuple = var_arg_type.accept(self) | ||
| assert isinstance(expanded_tuple, ProperType) and isinstance(expanded_tuple, TupleType) | ||
| expanded_items = expanded_tuple.items | ||
| fallback = var_arg_type.partial_fallback | ||
| elif isinstance(var_arg_type, Instance): | ||
| # We have something like Unpack[Tuple[Any, ...]] | ||
| expanded_items = list(var_arg_type.args) |
There was a problem hiding this comment.
Should we preserve this as an Instance? Are we converting a variable-length tuple to a single-item tuple?
There was a problem hiding this comment.
Thanks, I see what you mean (I think)! Does e4d02a4 address this?
I'm surprised no tests failed as a result of this.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16533