Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by avoiding setuptools 50.0 #9399

Closed
wants to merge 1 commit into from
Closed

Fix CI by avoiding setuptools 50.0 #9399

wants to merge 1 commit into from

Conversation

gvanrossum
Copy link
Member

Alternative to #9391; suggestion from pypa/setuptools#2352 (comment)

Test plan: see if all tests pass.

@gvanrossum
Copy link
Member Author

Well dang! The Travis build ran and passed but the Windows builds (are those the GitHub actions?) failed, seemingly due to mypyc compilation issues. I don't know what to try next. (Could these be legitimate failures that were landed because CI was failing anyways???)

@hauntsaninja
Copy link
Collaborator

Probably not landed legitimate failures. The last PR landed was #9376 which kind of hinged on CI working :-)

@gvanrossum
Copy link
Member Author

So maybe some different change broke the environment for Windows? Jelle's attempt to fix this (#9391) had the same Windows failures, as does harmless-looking #9387.

I note that the build logs, under "install tox", list "setuptools-50.0.3", which IIUC is the fixed version. In Jelle's PR it listed "setuptools-50.0.0". The failure in both looks the same (a whole block of tests failing, starting with testCompileMypyc. The most suspicious error seems to be LINK : fatal error LNK1104: cannot open file 'python37.lib'. Honestly I don't even know where the Windows build is configured these days. Anyway, this makes me think that we are dealing with a different failure than the setuptools thing.

@gvanrossum
Copy link
Member Author

Also I'm guessing that technically excluding setuptools 50.0 isn't enough -- we need to exclude 50.0.0 through 50.0.2, since the fix happened in 5.0.3: pypa/setuptools@400b71c

@hauntsaninja
Copy link
Collaborator

Closing since we merged #9400

@JelleZijlstra JelleZijlstra deleted the fix-ci branch September 2, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants