Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setuptools CI issue #9400

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Fix setuptools CI issue #9400

merged 1 commit into from
Sep 2, 2020

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Sep 2, 2020 •
edited
Loading

No description provided.

@gvanrossum
Copy link
Member

If this works, maybe combine with my idea and try "setuptools!=50.0" in both places?

@hauntsaninja hauntsaninja changed the title does it work Fix setuptools CI issue Sep 2, 2020
@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Sep 2, 2020 •
edited
Loading

Great, this seems to work.

Errors like cl : Command line warning D9002 : ignoring unknown option '/O0' smelt like we weren't using the right compiler. In mypyc/build.py, we gets the C compiler from from distutils import sysconfig, ccompiler, which is close enough that I continued to be suspicious. Maybe a separate setuptools issue though

@hauntsaninja hauntsaninja marked this pull request as ready for review September 2, 2020 22:59
gvanrossum
gvanrossum approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to land.

But we should eventually support newer setuptools versions too, otherwise we'll just break in a different way in the future, and it'll be another wild goose change.

@hauntsaninja
Copy link
Collaborator Author

Sure, I'll file an issue. So continues the packaging treadmill...

@hauntsaninja hauntsaninja merged commit 5906a5d into python:master Sep 2, 2020
This was referenced Sep 2, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauntsaninja @gvanrossum