Allow failure of commands when finding plugin dir #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirectXMan12
approved these changes
Nov 28, 2016
| '-path "*/krb5/plugins"' % search_path, | ||
| stderr=subprocess.STDOUT) | ||
| except subprocess.CalledProcessError: | ||
| options_raw = False |
There was a problem hiding this comment.
if you do have to do a revision, make this None, not False.
frozencemetery
force-pushed
the
bug/commands_can_fail
branch
from
5d499f0
to
583f306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, k5test will not find the plugin directory on Debian.
I distinctly remember this working before when I added the lib64 logic, so I wonder why subprocesses changed.