Test unbreaking travis through docker #109
Conversation
frozencemetery
force-pushed
the
travis_docker
branch
2 times, most recently
from
a4d5152
to
1b9c97a
Compare
frozencemetery
force-pushed
the
travis_docker
branch
from
1b9c97a
to
c963ea6
Compare
.travis.sh
Outdated
| if [ x"$PYTHON" = "x3" ]; then | ||
| yum -y install python3-pip python3-devel | ||
|
|
||
| # really not happy about this |
There was a problem hiding this comment.
salty comments are salty :-P
.travis.sh
Outdated
| @@ -20,7 +69,7 @@ F8_SETUP=$? | |||
| flake8 gssapi | |||
| F8_PY=$? | |||
|
|
|||
| flake8 gssapi --filename='*.pyx,*.pxd' --ignore=E225,E226,E227,E901,E402 | |||
| flake8 gssapi --filename='*.pyx,*.pxd' --ignore=E225,E226,E227,E901,E402,E999 | |||
There was a problem hiding this comment.
we should probably note what each of these are that we're skipping, and why.
|
If we do go with this, we need to make sure it doesn't break the release mechanisms at all. |
|
Looks like this adds between 30s and 1min to each test in the matrix, which is a bit of a time increase. It's not horrible, though. I wonder if we can ship images pre-installed with our test environment to speed things up? |
|
I do really like that we can now test across multiple distros easily, though. |
frozencemetery
force-pushed
the
travis_docker
branch
from
c963ea6
to
5372c93
Compare
|
(Addressed two comments in new version.) It's more time in the matrix, but it's far less work for me since I don't have to get each version of krb5 (and to a lesser extent, Python) working on Ubuntu-14.04. It also allows us to be more flexible with the underlying Travis infrastructure: we don't care what Ubuntu (or Linux, even) version underlies it. It even brings us closer to not needing sudo, if I understand it right. As for pre-installed images, I don't know; you know much more about container building than I do. |
|
Sorry, against 12.04; this build transparently upgrades to 14.04. |
frozencemetery
force-pushed
the
travis_docker
branch
3 times, most recently
from
76649e2
to
33f3efb
Compare
frozencemetery
force-pushed
the
travis_docker
branch
8 times, most recently
from
f5a94ec
to
11f706d
Compare
frozencemetery
force-pushed
the
travis_docker
branch
from
11f706d
to
53f002c
Compare
Travis will not pass until pythongssapi/k5test#3 is merged, and k5test passes. Currently only the RPM builders are broken on the latest k5test release.