Prevent GSSError/_display_status() infinite recursion #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Pulled some of the prep commits out of #109) |
|
I'm not a fan of assert() for flow control. Some flags (e.g. |
|
Christian Heimes <notifications@github.com> writes:
I'm not a fan of assert() for flow control. Some flags (e.g. ```-O```)
remove assert statements.
Understood. Do you have a recommendation instead? My original thought
was to raise an exception manually, and I only switched to
assert() because the assertion failure exception looked closest to the
kind of problem that was occurring.
|
|
Any other exception will do. I like |
frozencemetery
force-pushed
the
bug/display_forever
branch
from
4dc66ab
to
2068ffe
Compare
|
Switched to |
frozencemetery
force-pushed
the
bug/display_forever
branch
from
2068ffe
to
08efae8
Compare
DirectXMan12
suggested changes
Apr 4, 2017
gssapi/raw/misc.pyx
Outdated
| # but obviates infinite recursion into stack exhaustion. The | ||
| # exception raised here is handled by get_all_statuses(), which prints | ||
| # the code. | ||
| raise ValueError("gss_display_status call returned failure.") |
There was a problem hiding this comment.
please attach the error codes from gss_display_status into this message
I was unable to reproduce the problem, but this should prevent the issue. Resolves: pythongssapi#111
frozencemetery
force-pushed
the
bug/display_forever
branch
from
08efae8
to
b7e6c6c
Compare
|
Updated to include |
DirectXMan12
approved these changes
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to reproduce the problem, but this should prevent the issue (which is #111).