Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mutating the existing credentials object with add_cred #18

Closed
DirectXMan12 opened this issue Dec 18, 2014 · 0 comments · Fixed by #43
Closed

Support mutating the existing credentials object with add_cred #18

DirectXMan12 opened this issue Dec 18, 2014 · 0 comments · Fixed by #43
Assignees
@DirectXMan12
Labels
enhancement
Milestone
1.1.0

Comments

@DirectXMan12
Copy link
Member

We should support mutating the current credentials object with add_cred, which is possible if NULL is passed as the output cred object in the C API. We should follow up with a change to the high-level API
@DirectXMan12 DirectXMan12 added this to the 1.1.0 milestone Dec 23, 2014
@DirectXMan12 DirectXMan12 changed the title Support mutating the existing credentials object with Credentials.add Support mutating the existing credentials object with add_cred Feb 3, 2015
@DirectXMan12 DirectXMan12 self-assigned this Feb 10, 2015
DirectXMan12 added a commit that referenced this issue Feb 10, 2015
@DirectXMan12
Low-level: allow mutating input creds in add_cred
cf0df4a 
This commit adds an optional parameter to `add_cred`,
`mutate_input`, which allows `add_cred` to either
create a new set of credentials containing the input
credentials and the new credentials (False) or
to just modify the input credentials, adding the new
credentials directly to them (True).  Previously, only
the former was possible.

Closes #18.
@DirectXMan12 DirectXMan12 mentioned this issue Feb 10, 2015
Merged
DirectXMan12 added a commit that referenced this issue Feb 10, 2015
@DirectXMan12
Low-level: allow mutating input creds in add_cred
75a2b03 
This commit adds an optional parameter to `add_cred`,
`mutate_input`, which allows `add_cred` to either
create a new set of credentials containing the input
credentials and the new credentials (False) or
to just modify the input credentials, adding the new
credentials directly to them (True).  Previously, only
the former was possible.

Closes #18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DirectXMan12 DirectXMan12

Labels
enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Low-level: allow mutating input creds in add_cred pythongssapi/python-gssapi
1 participant
@DirectXMan12