Low-level: allow mutating input creds in add_cred #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an optional parameter to `add_cred`, `mutate_input`, which allows `add_cred` to either create a new set of credentials containing the input credentials and the new credentials (False) or to just modify the input credentials, adding the new credentials directly to them (True). Previously, only the former was possible. Closes #18.
DirectXMan12
force-pushed
the
feature/low-level/mutate-with-add-cred
branch
from
cf0df4a
to
75a2b03
Compare
|
Awesome, LGTM as long as travis agrees |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an optional parameter to
add_cred,mutate_input, which allowsadd_credto eithercreate a new set of credentials containing the input
credentials and the new credentials (False) or
to just modify the input credentials, adding the new
credentials directly to them (True). Previously, only
the former was possible.
Closes #18.