-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Drop dependency on python-should_be #219
tests: Drop dependency on python-should_be #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks. Are you okay to address the flake errors? And can you add a commit to revert the changes in 274886c so that we actually test it on 3.8?
(Let me know if you're not up for doing that and I'll take care of it.)
Migrate should_be assertions to unittest(stdlib) ones. This requires Python3.2+. Fixes: pythongssapi#215 Signed-off-by: Stanislav Levin <slev@altlinux.org>
b0b8057
to
47c74c1
Compare
This reverts commit 274886c to run CI against Python3.8. Signed-off-by: Stanislav Levin <slev@altlinux.org>
47c74c1
to
1e7dee0
Compare
This morning github experienced availability problems. |
Fails are related to MIT krb5 1.18.2: |
I think github derped here - I don't remember closing this and the "reopen" option is greyed out. I'm working on fixing the issue at the moment. |
This happened after renaming the branch master -> main. |
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
Migrate should_be assertions to unittest(stdlib) ones.
This requires Python3.2+.
Fixes: #215