tests: Drop dependency on python-should_be #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozencemetery
suggested changes
Jul 10, 2020
There was a problem hiding this comment.
Awesome, thanks. Are you okay to address the flake errors? And can you add a commit to revert the changes in 274886c so that we actually test it on 3.8?
(Let me know if you're not up for doing that and I'll take care of it.)
Migrate should_be assertions to unittest(stdlib) ones. This requires Python3.2+. Fixes: pythongssapi#215 Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin
force-pushed
the
migrate_from_shouldbe
branch
from
b0b8057
to
47c74c1
Compare
This reverts commit 274886c to run CI against Python3.8. Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin
force-pushed
the
migrate_from_shouldbe
branch
from
47c74c1
to
1e7dee0
Compare
|
This morning github experienced availability problems. |
|
Fails are related to MIT krb5 1.18.2: |
|
I think github derped here - I don't remember closing this and the "reopen" option is greyed out. I'm working on fixing the issue at the moment. |
|
This happened after renaming the branch master -> main. |
frozencemetery
pushed a commit
to frozencemetery/python-gssapi
that referenced
this pull request
Nov 12, 2020
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
frozencemetery
pushed a commit
to frozencemetery/python-gssapi
that referenced
this pull request
Nov 12, 2020
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
frozencemetery
pushed a commit
to frozencemetery/python-gssapi
that referenced
this pull request
Nov 12, 2020
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
frozencemetery
pushed a commit
to frozencemetery/python-gssapi
that referenced
this pull request
Nov 12, 2020
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
frozencemetery
pushed a commit
to frozencemetery/python-gssapi
that referenced
this pull request
Nov 13, 2020
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
frozencemetery
pushed a commit
to frozencemetery/python-gssapi
that referenced
this pull request
Nov 13, 2020
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate should_be assertions to unittest(stdlib) ones.
This requires Python3.2+.
Fixes: #215