-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests to run wth current setups #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robbie Harwood <rharwood@redhat.com>
frozencemetery
force-pushed
the
s4u2fix
branch
5 times, most recently
from
November 13, 2020 17:16
8b7664e
to
2357ea8
Compare
cipherboy
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Take the comments or leave them, there's more than I cared to point out, probably easier to find in an editor. Ran the test locally, work for me. :)
frozencemetery
force-pushed
the
s4u2fix
branch
from
November 13, 2020 20:12
2357ea8
to
8299ff3
Compare
Fixes: pythongssapi#215 Merges: pythongssapi#219 Signed-off-by: Stanislav Levin <slev@altlinux.org> Signed-off-by: Robbie Harwood <rharwood@redhat.com> [rharwood@redhat.com: bugfixes, rebase around six changes, not abusing Python equating empty and False, misc additional test cleanups, commit message]
These tests relied on rickety behavior and caching. Redo them to actually test impersonation. Fixes problems with krb5 >= 1.18.2. Resolves: pythongssapi#220 Signed-off-by: Robbie Harwood <rharwood@redhat.com>
This reverts 274886c. Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Our venerable hack of setting the hostname on the host doesn't seem to work on newer Fedora. Signed-off-by: Robbie Harwood <rharwood@redhat.com>
frozencemetery
force-pushed
the
s4u2fix
branch
from
November 13, 2020 20:18
8299ff3
to
93ce057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #219, which I've updated, and fixes #220 and #215.