Removed dataflow sync from Engine #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added deterministic methods - Fixed pytorch#818 - Fixed pytorch#795
7 tasks
sdesrozis
reviewed
Apr 18, 2020
| pass | ||
|
|
||
|
|
||
| def _repr_rng_state(rng_states): |
There was a problem hiding this comment.
Why do we need this function ?
There was a problem hiding this comment.
This can be helpful to debug random state
sdesrozis
approved these changes
Apr 18, 2020
6 tasks
vfdev-5
added a commit
that referenced
this pull request
Apr 28, 2020
* Removed dataflow sync from Engine (#938) - added deterministic methods - Fixed #818 - Fixed #795 * Added DeterministicEngine (#939) * Fixed broken GPU test * Update examples and docs (#957) * Added DeterministicEngine * [WIP] Update examples * Fixes #941 for deterministic engine - added tests for both engines * Update examples/mnist/mnist_save_resume_engine * Updated mnist example, fixed minor bug in deterministic * autopep8 fix * Updated cifar10 docs + minor cosmetics * autopep8 fix * Cosmetics x * Commented results for single node, multi-gpus * Fixed mnist_save_resume_engine smoke tests Co-authored-by: AutoPEP8 <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PR (1/3) to that splits #895
Removed dataflow sync from Engine
Added new engine events (used with deterministic methods)
DATALOADER_STOP_ITERATION : engine's specific event triggered when dataloader has no more data to provide
TERMINATE_SINGLE_EPOCH : triggered when the run is about to end the current epoch,
after receiving :meth:
~ignite.engine.Engine.terminate_epoch()call.TERMINATE : triggered when the run is about to end completely,
after receiving :meth:
~ignite.engine.Engine.terminate()call.Check list: