Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified engine - BC breaking change #940

Merged
merged 7 commits into from
Apr 28, 2020
Merged

Simplified engine - BC breaking change #940

merged 7 commits into from
Apr 28, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Apr 18, 2020

This PR will also closes indirectly the issues:

Description:
Composed of #938 #939 #957 = #895

ToDo:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5 vfdev-5 mentioned this pull request Apr 26, 2020
3 tasks
* Added DeterministicEngine

* [WIP] Update examples

* Fixes #941 for deterministic engine
- added tests for both engines

* Update examples/mnist/mnist_save_resume_engine

* Updated mnist example, fixed minor bug in deterministic

* autopep8 fix

* Updated cifar10 docs
+ minor cosmetics

* autopep8 fix

* Cosmetics x

* Commented results for single node, multi-gpus

* Fixed mnist_save_resume_engine smoke tests

Co-authored-by: AutoPEP8 <>
@vfdev-5 vfdev-5 marked this pull request as ready for review April 28, 2020 10:06
@vfdev-5 vfdev-5 merged commit 67eb7b8 into master Apr 28, 2020
@vfdev-5 vfdev-5 deleted the new_engine branch April 28, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant