-
Notifications
You must be signed in to change notification settings - Fork 23k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.circleci: Add workflows for Python 3.8 #31948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if things pass, shipit!
After a second glance through at these changes I don't think any python 3.8 specific tests will be run on PRs and that these changes only apply to the @kostmo where would the other places to change be so that we can have full Python 3.8 coverage? |
Yes, Python version lists are scattered in a few different places. I think this will find the ones that matter:
I wish it was as simple as a single list! |
💊 CircleCI build failures summary and remediationsAs of commit 01abf37: None of the build failures appear to be your fault.
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. ❄️ 1 failure recognized as flakyThe following build failures have been detected as flaky and may not be your fault: pytorch_linux_xenial_cuda10_1_cudnn7_py3_NO_AVX_NO_AVX2_test (1/1)Step: "Test" (full log | pattern match details) ❄️
|
df46e06
to
d5f8fb3
Compare
Whoo! macOS builds are ready to go: |
Summary: Adds circleci workflows to validate builds on Python 3.8 Test Plan: Observe circlci builds pass for Python 3.8 Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seemethere is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@seemethere merged this pull request in da39091. |
Summary: Done by just editing `.circleci/cimodel/data/dimensions.py` to include `3.8` and then regenerated using `.circleci/regenerate.sh` cc kostmo, mingbowan, ezyang, soumith Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: pytorch#31948 Differential Revision: D19602069 Pulled By: seemethere fbshipit-source-id: ac57fde9d0c491c7d948a3f5944c3cb324d403c0
Summary: Done by just editing `.circleci/cimodel/data/dimensions.py` to include `3.8` and then regenerated using `.circleci/regenerate.sh` cc kostmo, mingbowan, ezyang, soumith Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: pytorch#31948 Differential Revision: D19602069 Pulled By: seemethere fbshipit-source-id: ac57fde9d0c491c7d948a3f5944c3cb324d403c0
Done by just editing
.circleci/cimodel/data/dimensions.py
to include3.8
and then regenerated using.circleci/regenerate.sh
cc @kostmo, @mingbowan, @ezyang, @soumith
Signed-off-by: Eli Uriegas eliuriegas@fb.com