Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.circleci: Bump python3.7 -> python3.8 #1731

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented Jan 8, 2020

@fmassa
Copy link
Member

fmassa commented Jan 15, 2020

Hi Eli,

Thanks for the PR!

The test failures that you are seeing are unrelated and have been fixed in master, can you rebase your PR?

@seemethere seemethere force-pushed the python38 branch 2 times, most recently from 31cd00c to 33a17af Compare January 15, 2020 17:26
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #1731 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1731   +/-   ##
======================================
  Coverage    0.43%   0.43%           
======================================
  Files          92      92           
  Lines        7386    7386           
  Branches     1111    1111           
======================================
  Hits           32      32           
  Misses       7346    7346           
  Partials        8       8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e130c6c...52852ad. Read the comment docs.

@seemethere seemethere changed the title WIP .circleci: Bump python3.7 -> python3.8 .circleci: Bump python3.7 -> python3.8 Jan 15, 2020
@seemethere seemethere marked this pull request as ready for review January 15, 2020 17:29
@seemethere seemethere requested a review from fmassa January 15, 2020 17:29
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but Python 3.8 CI is not working yet.

@bottler
Copy link
Contributor

bottler commented Jan 20, 2020

I think mac and windows are failing because torch isn't yet working for them on python 3.8.

One problem for the linux conda builds is the dependency on typing, which is only relevant for python 3.5 and earlier, but depending on it for python 3.6 and 3.7 is somehow tolerated by conda.
There's a line

typing -> python[version='2.7.*|3.4.*|3.5.*|3.6.*|>=2.7,<2.8.0a0|>=3.5,<3.6.0a0|>=3.6,<3.7.0a0|>=3.7,<3.8.0a0']

in the output of one of the failed builds.

I plan to make a separate PR soon which makes typing only get included when necessary, unless someone suggests otherwise.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere
Copy link
Member Author

seemethere commented Jan 28, 2020

Just did a rebase off of master with @bottler's changes, should hopefully resolve all of the issues.

EDIT: Actually needed to run a nightly run of upstream pytorch/pytorch after we merged in my changes to add python 3.8 to the nightly pipeline.

@seemethere seemethere merged commit 30538b5 into pytorch:master Jan 29, 2020
@seemethere seemethere deleted the python38 branch January 29, 2020 06:23
fmassa pushed a commit to fmassa/vision-1 that referenced this pull request Mar 20, 2020
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants