-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.circleci: Bump python3.7 -> python3.8 #1731
Conversation
Hi Eli, Thanks for the PR! The test failures that you are seeing are unrelated and have been fixed in master, can you rebase your PR? |
31cd00c
to
33a17af
Compare
Codecov Report
@@ Coverage Diff @@
## master #1731 +/- ##
======================================
Coverage 0.43% 0.43%
======================================
Files 92 92
Lines 7386 7386
Branches 1111 1111
======================================
Hits 32 32
Misses 7346 7346
Partials 8 8 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, but Python 3.8 CI is not working yet.
I think mac and windows are failing because torch isn't yet working for them on python 3.8. One problem for the linux conda builds is the dependency on
in the output of one of the failed builds. I plan to make a separate PR soon which makes |
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Just did a rebase off of EDIT: Actually needed to run a nightly run of upstream |
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Adds python 3.8 to the matrix.
Related PRs: