conda build only needs typing if python is 3.5 #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those two windows builds were already failing I think. |
fmassa
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Awesome, thanks a lot Jeremy!
cc @peterjc123 if we need to do something similar for Windows
fmassa
pushed a commit
to fmassa/vision-1
that referenced
this pull request
Jan 28, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 28, 2020
Summary: Pull Request resolved: #1820 Reviewed By: thibautlavril Differential Revision: D19599200 Pulled By: fmassa fbshipit-source-id: 773b9858f4d3055c38382e65f429be39a7a3a954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a wider effort to get the build working on Python 3.8, see #1731, it will be useful to not depend on the
typinglibrary, which is only useful for Python 3.5 and older.