Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Educational] Typing .py files iteratively with mypy #1512

Open
msaroufim opened this issue Mar 15, 2022 · 1 comment
Open

[Educational] Typing .py files iteratively with mypy #1512

msaroufim opened this issue Mar 15, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@msaroufim
Copy link
Member

msaroufim commented Mar 15, 2022

We just added #1858 support so a good first issue for anyone new to torchserve or open source python projects in general I'd recommend the following

  1. Pick any file in serve/ts
  2. Add type annotations - for an example you can checkout https://github.com/pytorch/serve/blob/master/ts/context.py
  3. Run mypy path_to_file_you_annotated.py
  4. If you don't see any issues then make a PR and make sure the mypy lint action passes
@msaroufim msaroufim added the good first issue Good for newcomers label Mar 15, 2022
@msaroufim msaroufim changed the title Typing .py files iteratively Typing .py files iteratively with pyre Mar 15, 2022
@msaroufim msaroufim changed the title Typing .py files iteratively with pyre [Educational] Typing .py files iteratively with pyre Mar 15, 2022
@msaroufim msaroufim closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2022
@msaroufim msaroufim reopened this Jan 4, 2023
@msaroufim msaroufim changed the title [Educational] Typing .py files iteratively with pyre [Educational] Typing .py files iteratively with mypy Jan 4, 2023
@josephcalise
Copy link
Contributor

I would love to take care of this issue on any files that need type annotations in serve/ts, are there any specific ones that are still open? I am new to contributing to open source, I have identified serve/ts/model_server.py as something I am able to complete right now, and will continue to look into the rest of the files to try to understand the types and complete any other files I can.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants
@msaroufim @josephcalise and others