-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typehints for model_loader and model_service_worker #2540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's see what ci says
Codecov Report
@@ Coverage Diff @@
## master #2540 +/- ##
==========================================
+ Coverage 72.64% 72.71% +0.06%
==========================================
Files 79 79
Lines 3733 3742 +9
Branches 58 58
==========================================
+ Hits 2712 2721 +9
Misses 1017 1017
Partials 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hm, I haven't been able to replicate the ci regression test errors locally. It seems odd that in the first run only the GPU regression test failed, but after merging in master the GPU regression test passed but the CPU and macOS failed. |
Regressions I believe are unrelated to you so we can still merge this |
Description
None
to makemypy
happy in two files:ts/model_loader.py
,ts/model_service_worker.py
None
check inhandle_connection
Related to #1512
Type of change
Code quality - typehints
Feature/Issue validation/testing
None
checking inhandle_connection
.See
ts/tests/unit_tests/test_model_service_worker.py
mypy
on changed filestorchserve_sanity.py
)test/regression_tests.py
)Checklist: