Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on token authentication PR comments #3185

Closed
mreso opened this issue Jun 7, 2024 · 6 comments
Closed

Follow up on token authentication PR comments #3185

mreso opened this issue Jun 7, 2024 · 6 comments
Assignees
@udaij12
Milestone
v0.12.0

Comments

@mreso
Copy link
Collaborator

mreso commented Jun 7, 2024

🚀 The feature

Follow up on refactor comments in #3163

Motivation, pitch

Follow up on refactor comments in #3163

Alternatives

No response

Additional context

No response
@mreso mreso added this to the v0.12.0 milestone Jun 7, 2024
@mreso mreso mentioned this issue Jun 12, 2024
Merged
@mreso
Copy link
Collaborator Author

mreso commented Jun 13, 2024

We also need to go through all examples and add the right options.

@mreso
Copy link
Collaborator Author

mreso commented Jun 13, 2024

Benchmark tool is also affected.

@mreso
Copy link
Collaborator Author

mreso commented Jun 13, 2024

This needs to be described in api docs as well.

@udaij12 udaij12 mentioned this issue Jun 13, 2024
Merged
@udaij12
Copy link
Collaborator

udaij12 commented Jun 13, 2024

Benchmark tool is also affected.

Benchmark tool should be fixed in this PR #3188

@udaij12
Copy link
Collaborator

udaij12 commented Jun 14, 2024

Doc changes in this PR #3183

@udaij12
Copy link
Collaborator

udaij12 commented Jul 9, 2024

Think we have address all token related PRs. Closing this issue.

@udaij12 udaij12 closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@udaij12 udaij12

Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

No branches or pull requests
2 participants
@mreso @udaij12