Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security documentation update #3183

Merged
merged 41 commits into from
Jul 3, 2024
Merged

Security documentation update #3183

merged 41 commits into from
Jul 3, 2024

Conversation

udaij12
Copy link
Collaborator

@udaij12 udaij12 commented Jun 7, 2024 •
edited
Loading

Description

Documentation update for security PRs #3163 and #3165

To be merged after both security PRs are merged

@udaij12 udaij12 marked this pull request as ready for review June 7, 2024 22:21
agunapal
agunapal requested changes Jun 13, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@udaij12 udaij12 mentioned this pull request Jun 14, 2024
Closed
agunapal
agunapal requested changes Jun 14, 2024
View reviewed changes
docs/token_authorization_api.md Outdated Show resolved Hide resolved
mreso
mreso requested changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this more prominent so users are aware of this. Please also add a prominent logging message about the changes when torchserve starts (framed in ##### or something). Also add where the keyfile is located ( and if not already there add an example on how to send requests to models now)

README.md Outdated Show resolved Hide resolved
docs/inference_api.md Outdated Show resolved Hide resolved
docs/management_api.md Show resolved Hide resolved
docs/management_api.md Outdated Show resolved Hide resolved
docs/management_api.md Show resolved Hide resolved
docs/model_api_control.md Outdated Show resolved Hide resolved
docs/model_api_control.md Outdated Show resolved Hide resolved
docs/token_authorization_api.md Outdated Show resolved Hide resolved
mreso
mreso approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but otherwise this LGTM now

frontend/server/src/main/java/org/pytorch/serve/http/TokenAuthorizationHandler.java Show resolved Hide resolved
mreso
mreso requested changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align the argument name to --enable-model-api and make sure you're usage is right in the doc. AFAIK --enable_model_api won't work.

benchmarks/utils/system_under_test.py Outdated Show resolved Hide resolved
benchmarks/utils/system_under_test.py Outdated Show resolved Hide resolved
docs/management_api.md Outdated Show resolved Hide resolved
docs/management_api.md Outdated Show resolved Hide resolved
docs/management_api.md Outdated Show resolved Hide resolved
frontend/server/src/test/resources/config.properties Outdated Show resolved Hide resolved
frontend/server/src/test/resources/config_snapshot.properties Outdated Show resolved Hide resolved
frontend/server/src/main/java/org/pytorch/serve/util/ConfigManager.java Outdated Show resolved Hide resolved
kubernetes/kserve/tests/configs/mnist_v1_cpu.yaml Outdated Show resolved Hide resolved
test/pytest/test_utils.py Outdated Show resolved Hide resolved
mreso
mreso requested changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

frontend/server/src/main/java/org/pytorch/serve/util/ConfigManager.java Outdated Show resolved Hide resolved
namannandan
namannandan reviewed Jul 2, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
namannandan
namannandan reviewed Jul 2, 2024
View reviewed changes
docker/README.md Outdated Show resolved Hide resolved
namannandan
namannandan reviewed Jul 2, 2024
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
namannandan
namannandan reviewed Jul 2, 2024
View reviewed changes
docs/management_api.md Outdated Show resolved Hide resolved
namannandan
namannandan reviewed Jul 2, 2024
View reviewed changes
docs/management_api.md Outdated Show resolved Hide resolved
namannandan
namannandan reviewed Jul 2, 2024
View reviewed changes
kubernetes/README.md Outdated Show resolved Hide resolved
udaij12 and others added 3 commits July 2, 2024 16:09
@udaij12 udaij12 enabled auto-merge July 2, 2024 23:57
agunapal
agunapal approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@udaij12 udaij12 added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit dc08344 Jul 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agunapal agunapal agunapal approved these changes

@mreso mreso mreso approved these changes

@namannandan namannandan namannandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@udaij12 @mreso @namannandan @agunapal