Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating night CIs to account for model control and token auth #3188

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Updating night CIs to account for model control and token auth #3188

merged 4 commits into from
Jun 13, 2024

Conversation

udaij12
Copy link
Collaborator

@udaij12 udaij12 commented Jun 12, 2024 •
edited
Loading

Description

Adding --model-api-enabled --disable-token to nightly benchmark tests to ensure they run

Adding model_api_enabled=true and disable_token_authorization=true to kubernetes nightly test
Test: Kubernetes nightly test

@udaij12 udaij12 marked this pull request as ready for review June 12, 2024 19:07
agunapal
agunapal approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@udaij12 udaij12 added this pull request to the merge queue Jun 13, 2024
Merged via the queue into master with commit 9336ad2 Jun 13, 2024
12 checks passed
@udaij12 udaij12 deleted the model_update branch June 13, 2024 17:52
@udaij12 udaij12 changed the title Updating night CIs to account for model control Updating night CIs to account for model control and token auth Jun 13, 2024
@udaij12 udaij12 mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agunapal agunapal agunapal approved these changes

@namannandan namannandan namannandan approved these changes

@mreso mreso Awaiting requested review from mreso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@udaij12 @namannandan @agunapal