-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend IMetrics, LogMetric and PrometheusMetric #2165
Conversation
frontend/server/src/main/java/org/pytorch/serve/metrics/MetricBuilder.java
Outdated
Show resolved
Hide resolved
...end/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusCounter.java
Outdated
Show resolved
Hide resolved
...end/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusCounter.java
Outdated
Show resolved
Hide resolved
...end/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusCounter.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusGauge.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusGauge.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusGauge.java
Outdated
Show resolved
Hide resolved
...tend/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusMetric.java
Outdated
Show resolved
Hide resolved
Reformat code for readability
Codecov Report
@@ Coverage Diff @@
## master #2165 +/- ##
=======================================
Coverage 71.41% 71.41%
=======================================
Files 73 73
Lines 3348 3348
Branches 57 57
=======================================
Hits 2391 2391
Misses 954 954
Partials 3 3 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Add better prometheus metric help strings
...tend/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusMetric.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/LogMetric.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/MetricBuilder.java
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/MetricBuilder.java
Outdated
Show resolved
Hide resolved
...tend/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusMetric.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/MetricBuilder.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/MetricBuilder.java
Show resolved
Hide resolved
...tend/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusMetric.java
Outdated
Show resolved
Hide resolved
...tend/server/src/main/java/org/pytorch/serve/metrics/format/prometheous/PrometheusMetric.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/LogMetric.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/LogMetric.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/LogMetric.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
Approving on @lxning behalf based on the above comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lxning Could you please update the appropriate README files for the additional metrics we are collecting.
Also, from. a user point of view, do they have to enable some config to get these metrics?
@agunapal Currently there aren't any new metrics that are going to be collected. The existing metrics are being migrated to a new implementation that supports two modes, i.e The default mode will be This PR implements the necessary helper classes for the frontend metrics implementation refactoring. |
Description
Implementation of frontend metrics helper classes for
LogMetric
andPrometheusMetric
Design: #1492
Fixes #2139
Type of change
Feature/Issue validation/testing
Unit tests included in this PR
Checklist: