-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend metrics configuration handling #2190
Frontend metrics configuration handling #2190
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
- Coverage 71.47% 71.38% -0.09%
==========================================
Files 73 73
Lines 3341 3341
Branches 57 57
==========================================
- Hits 2388 2385 -3
- Misses 950 953 +3
Partials 3 3 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TsMetrics and ModelMetrics are exactly same. it is not necessary to have them.
Only need:
- MetricConfiguraiton.java
- MetricSpec.java
...er/src/main/java/org/pytorch/serve/metrics/configuration/YAMLMetricConfigurationHandler.java
Outdated
Show resolved
Hide resolved
Addressed review comments:
|
88d4172
to
6bb17d6
Compare
frontend/server/src/main/java/org/pytorch/serve/util/ConfigManager.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/configuration/MetricConfiguration.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/configuration/MetricTypes.java
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/configuration/MetricTypes.java
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/configuration/MetricTypes.java
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/util/ConfigManager.java
Outdated
Show resolved
Hide resolved
frontend/server/src/main/java/org/pytorch/serve/metrics/configuration/MetricConfiguration.java
Outdated
Show resolved
Hide resolved
31c1d6d
to
0576bd4
Compare
Description
Implementation of frontend metrics configuration parsing and validation.
Design: #1492
Fixes #2134
Type of change
Feature/Issue validation/testing
Checklist: