Adding M1 to Ci workflows #2934
Conversation
| steps: | ||
| - name: Setup Python 3.8 | ||
| - name: Setup Python for M1 |
There was a problem hiding this comment.
Why python 3.10? It'll make releasing the binaries a bit annoying if each platform requires a different python version
There was a problem hiding this comment.
Github macos-14 does not work with python setup less than 3.10 actions/setup-python#808
There was a problem hiding this comment.
Reading through that issue it seems like the issue was fixed, mind retriggering with 3.8
There was a problem hiding this comment.
Ok so assuming the macos-14 jobs pass we should be good to merge this, they are likely not a required check so watch out and don't add this to merge queue before confirming
I'd also add a TODO referencing actions/setup-python#808 in both CI jobs so we can remember to remove the python 3.10 stuff when ready
Description
Adding M1 compatibility to CI jobs.
Tested:
Regression test
Ci test
Issue #2555
TODO
Change python back 3.8 when this issue is resolved.