Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torchserve support for Intel GPUs #3132

Merged
merged 37 commits into from
Jun 25, 2024
Merged

Torchserve support for Intel GPUs #3132

merged 37 commits into from
Jun 25, 2024

Conversation

krish-navulla
Copy link
Contributor

@krish-navulla krish-navulla commented May 3, 2024 •
edited
Loading

Description

This PR will enable torchserve to leverage Intel GPU devices. This adds a config ipex_gpu_enable, to allow gpu enablement in base_handler.py

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@krish-navulla krish-navulla marked this pull request as draft May 3, 2024 18:17
@krish-navulla krish-navulla marked this pull request as ready for review May 3, 2024 18:18
@krish-navulla krish-navulla marked this pull request as draft May 3, 2024 18:32
@min-jean-cho min-jean-cho self-requested a review May 3, 2024 18:46
@krish-navulla krish-navulla marked this pull request as ready for review May 6, 2024 21:18
@krish-navulla krish-navulla mentioned this pull request May 10, 2024
Merged
5 tasks
@agunapal
Copy link
Collaborator

Hi @Kanya-Mo Can you please resolve the merge conflict. Rest of the PR looks good

agunapal
agunapal reviewed Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

frontend/server/src/main/java/org/pytorch/serve/util/ConfigManager.java Outdated Show resolved Hide resolved
@agunapal
Copy link
Collaborator

Hi @Kanya-Mo Can you please format the frontend file. CI is failing because of this.

agunapal
agunapal approved these changes Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal enabled auto-merge June 22, 2024 17:59
@agunapal agunapal added this to the v0.12.0 milestone Jun 22, 2024
@agunapal
Copy link
Collaborator

Hi @Kanya-Mo Please check the lint workflow and resolve the lint issue. The PR won't merge without this passing

auto-merge was automatically disabled June 24, 2024 18:21

Head branch was pushed to by a user without write access

@agunapal agunapal enabled auto-merge June 25, 2024 16:53
@agunapal agunapal added this pull request to the merge queue Jun 25, 2024
Merged via the queue into pytorch:master with commit c7bbf2c Jun 25, 2024
12 checks passed
@Kanya-Mo Kanya-Mo mentioned this pull request Jul 1, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kanya-Mo Kanya-Mo Kanya-Mo left review comments

@anupren anupren anupren left review comments

@lxning lxning lxning left review comments

@agunapal agunapal agunapal approved these changes

@min-jean-cho min-jean-cho Awaiting requested review from min-jean-cho

Assignees
No one assigned
Labels
torch.compile
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@krish-navulla @agunapal @lxning @anupren @Kanya-Mo