Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torchserve Metrics support for Intel GPUs enabled #3141

Merged
merged 17 commits into from
Jun 25, 2024

Conversation

krish-navulla
Copy link
Contributor

@krish-navulla krish-navulla commented May 10, 2024

Description

This PR is dependent on successful merge of #3132

This pull request (PR) leverages xpu-smi to acquire Intel GPU metrics. For this functionality to operate correctly, #3132 must be merged, and in the config.properties file, ipex_gpu_enable=true must be configured.

To conduct testing on this PR, you can fetch the code from #3132 , compile the frontend jar, and update the Python environment files with the files from the fetched code.

Please review this pull request. @min-jean-cho , can you please take a look?

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the file intel_gpu_metric_collector.py to the example folder in the other PR.

@Kanya-Mo Kanya-Mo mentioned this pull request Jun 20, 2024
6 tasks
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal enabled auto-merge June 22, 2024 17:59
@agunapal
Copy link
Collaborator

Hi @Kanya-Mo Could you please fix the lint issue here as well

auto-merge was automatically disabled June 25, 2024 17:38

Head branch was pushed to by a user without write access

@Kanya-Mo
Copy link
Contributor

Sure. Done fixing.

@agunapal agunapal enabled auto-merge June 25, 2024 17:49
auto-merge was automatically disabled June 25, 2024 18:11

Head branch was pushed to by a user without write access

@Kanya-Mo
Copy link
Contributor

Sorry just fix the rest of files. Could you please start the workflows again?

@agunapal agunapal added this pull request to the merge queue Jun 25, 2024
Merged via the queue into pytorch:master with commit 1fc8bd0 Jun 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants