Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set model_snapshot_path to None to prevent unbound local error #3336

Conversation

johnathanchiu
Copy link
Contributor

@johnathanchiu johnathanchiu commented Oct 1, 2024

Description

Adding a variable model_snapshot_path to None should resolve the error introduced in the following issue.

Fixes #(3335)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal
Copy link
Collaborator

agunapal commented Oct 2, 2024

Thanks @johnathanchiu If you could please refer to my PR and make this pythonic and try out with llama 3.2 and update the README, that would be great. I can approve yours and close mine

@johnathanchiu
Copy link
Contributor Author

just made the requested changes! I I also tested locally as well. It's working.

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution

@agunapal agunapal mentioned this pull request Oct 3, 2024
10 tasks
@agunapal agunapal added this pull request to the merge queue Oct 3, 2024
Merged via the queue into pytorch:master with commit 9d10087 Oct 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants