Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set model_snapshot_path to None to prevent unbound local error #3336

Merged
merged 4 commits into from
Oct 3, 2024
Merged

set model_snapshot_path to None to prevent unbound local error #3336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
080f441
set model_snapshot_path to None to prevent unbound local error
johnathanchiu Oct 1, 2024
98a766e
address PR comments with pythonic usage, fix README
johnathanchiu Oct 3, 2024
2412e8c
small change
johnathanchiu Oct 3, 2024
76136b2
revert formatting changes
johnathanchiu Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ Refer to [torchserve docker](docker/README.md) for details.
#### VLLM Engine
```bash
# Make sure to install torchserve with pip or conda as described above and login with `huggingface-cli login`
python -m ts.llm_launcher --model_id meta-llama/Meta-Llama-3.1-8B-Instruct --disable_token_auth
python -m ts.llm_launcher --model_id meta-llama/Llama-3.2-3B-Instruct --disable_token_auth

# Try it out
curl -X POST -d '{"model":"meta-llama/Meta-Llama-3.1-8B-Instruct", "prompt":"Hello, my name is", "max_tokens": 200}' --header "Content-Type: application/json" "http://localhost:8080/predictions/model/1.0/v1/completions"
curl -X POST -d '{"model":"meta-llama/Llama-3.2-3B-Instruct", "prompt":"Hello, my name is", "max_tokens": 200}' --header "Content-Type: application/json" "http://localhost:8080/predictions/model/1.0/v1/completions"
```

#### TRT-LLM Engine
Expand Down
5 changes: 3 additions & 2 deletions ts/llm_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,9 @@ def main(args):

model_store_path = Path(args.model_store)
model_store_path.mkdir(parents=True, exist_ok=True)
if args.engine == "trt_llm":
model_snapshot_path = download_model(args.model_id)
model_snapshot_path = (
download_model(args.model_id) if args.engine == "trt_llm" else None
)

with create_mar_file(args, model_snapshot_path):
if args.engine == "trt_llm":
Expand Down
Loading