Skip to content

Commit

Permalink
Python 3.11 wheels builds (#2105)
Browse files Browse the repository at this point in the history
3.11 Linux and MacOS x86 Wheels seem to be working for vision. These
have also been unittested with 3.11 in
pytorch/vision#7155.

Current failures are in text, which are failing since torchdata 3.11
wheels are not available. We will have 3.11 torchdata wheels once
pytorch/data#990 is merged. After that, will
verify that text wheels are working.

Could not do conda builds since a 3.11-compliant `conda-build` is not
yet available. This PR does not explicitly work on Windows compliance.
  • Loading branch information
osalpekar authored Feb 8, 2023
1 parent dddd31c commit 3491aa6
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 15 deletions.
30 changes: 21 additions & 9 deletions .github/actions/setup-binary-builds/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,26 @@ runs:
set -euxo pipefail
CONDA_ENV="${RUNNER_TEMP}/conda_environment_${GITHUB_RUN_ID}"
conda create \
--yes \
--prefix "${CONDA_ENV}" \
"python=${PYTHON_VERSION}" \
cmake=3.22 \
conda-build=3.21 \
ninja=1.10 \
pkg-config=0.29 \
wheel=0.37
if [[ "${PYTHON_VERSION}" = "3.11" ]]; then
# conda-build not available for Python 3.11
conda create \
--yes \
--prefix "${CONDA_ENV}" \
"python=${PYTHON_VERSION}" \
cmake=3.22 \
ninja=1.10 \
pkg-config=0.29 \
wheel=0.37
else
conda create \
--yes \
--prefix "${CONDA_ENV}" \
"python=${PYTHON_VERSION}" \
cmake=3.22 \
conda-build=3.21 \
ninja=1.10 \
pkg-config=0.29 \
wheel=0.37
fi
echo "CONDA_ENV=${CONDA_ENV}" >> "${GITHUB_ENV}"
echo "CONDA_RUN=conda run -p ${CONDA_ENV}" >> "${GITHUB_ENV}"
10 changes: 5 additions & 5 deletions .github/workflows/test_build_wheels_linux_with_cuda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ jobs:
post-script: packaging/post_build_script.sh
smoke-test-script: test/smoke_test.py
package-name: torchvision
- repository: pytorch/torchrec
pre-script: ""
post-script: ""
smoke-test-script: ""
package-name: torchrec
# - repository: pytorch/torchrec
# pre-script: ""
# post-script: ""
# smoke-test-script: ""
# package-name: torchrec
uses: ./.github/workflows/build_wheels_linux.yml
name: ${{ matrix.repository }}
with:
Expand Down
2 changes: 1 addition & 1 deletion tools/scripts/generate_binary_build_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
mod = sys.modules[__name__]

PYTHON_ARCHES_DICT = {
"nightly": ["3.8", "3.9", "3.10"],
"nightly": ["3.8", "3.9", "3.10", "3.11"],
"test": ["3.7", "3.8", "3.9", "3.10"],
"release": ["3.7", "3.8", "3.9", "3.10"],
}
Expand Down

0 comments on commit 3491aa6

Please sign in to comment.