Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 Linux CPU Unittesting #7155

Closed
wants to merge 12 commits into from

Conversation

osalpekar
Copy link
Member

No description provided.

@pmeier
Copy link
Contributor

pmeier commented Feb 1, 2023

Hey @osalpekar, supporting 3.11 for us means that we'll have to wait until the conda defaults channel supports it as well as all of our dependencies for it. Unfortunately, conda-forge is not an option since we don't want to have builds from multiple channels. Thus, we'll just have to wait for now. There is #7108 that will include your change here minus the compatibility stuff.

@pmeier pmeier closed this Feb 1, 2023
@osalpekar
Copy link
Member Author

Using this as a branch to do experiments, and I want to try out Nikita's suggestion from here: #7049 (comment). Not necessarily planning on merging this, but using this to figure out all the blockers to 3.11 support.

@osalpekar osalpekar reopened this Feb 2, 2023
@osalpekar
Copy link
Member Author

osalpekar commented Feb 2, 2023

Got all the 3.11 tests to run and pass, except for the 7 tests that depended on PyAV: https://github.com/pytorch/vision/actions/runs/4078992818/jobs/7029872042.

In a previous commit, pyav installation failed, but it appears there are Python 3.11 manylinux wheels available for PyAV (https://files.pythonhosted.org/packages/55/ac/8c31205c9b49ea3e0111276a2f3ea8dae42dd026cee0832e46658c9a4650/av-10.0.0-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl), so will take a closer look at why those could not be installed earlier.

@pmeier
Copy link
Contributor

pmeier commented Feb 3, 2023

av==10.0.0 contains a bug that breaks our stuff. See #6790. This is why we don't install it:

python3 -m pip install pytest pytest-mock 'av<10'

According to #6814 (comment), the bug was fixed so we just need to wait for the next release to be able to support av>=10.

However, you are right than all versions for av<10 don't have a wheel for Python 3.11. So not sure what to do about that.

@osalpekar
Copy link
Member Author

Getting 16145 tests to pass, 7 are failing due to lack of appropriate av library which those 7 tests depend on.

osalpekar added a commit to pytorch/test-infra that referenced this pull request Feb 8, 2023
3.11 Linux and MacOS x86 Wheels seem to be working for vision. These
have also been unittested with 3.11 in
pytorch/vision#7155.

Current failures are in text, which are failing since torchdata 3.11
wheels are not available. We will have 3.11 torchdata wheels once
pytorch/data#990 is merged. After that, will
verify that text wheels are working.

Could not do conda builds since a 3.11-compliant `conda-build` is not
yet available. This PR does not explicitly work on Windows compliance.
@pmeier
Copy link
Contributor

pmeier commented Feb 8, 2023

7 are failing due to lack of appropriate av library which those 7 tests depend on.

Nope, they are failing because we don't have any av installed. Since av is an optional dependency, we should not depend on it in the test suite either. Let me send a PR that removes this hard dependency to unblock this PR.

@pmeier
Copy link
Contributor

pmeier commented Feb 10, 2023

@osalpekar
Copy link
Member Author

We can close this in favor of #7189

@osalpekar osalpekar closed this Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants