Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize str argument verification in datasets #1167

Merged
merged 9 commits into from
Jul 26, 2019

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jul 25, 2019

First steps towards #1132. I left some TODOs and FIXME for review / discussion.

@codecov-io
Copy link

codecov-io commented Jul 25, 2019

Codecov Report

Merging #1167 into master will increase coverage by 0.56%.
The diff coverage is 52.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
+ Coverage   65.11%   65.68%   +0.56%     
==========================================
  Files          72       72              
  Lines        5619     5607      -12     
  Branches      867      857      -10     
==========================================
+ Hits         3659     3683      +24     
+ Misses       1699     1668      -31     
+ Partials      261      256       -5
Impacted Files Coverage Δ
torchvision/datasets/imagenet.py 90.9% <100%> (+3.4%) ⬆️
torchvision/datasets/cityscapes.py 80% <100%> (+10%) ⬆️
torchvision/datasets/svhn.py 68.75% <100%> (+2.75%) ⬆️
torchvision/datasets/caltech.py 21.83% <25%> (+0.24%) ⬆️
torchvision/datasets/mnist.py 51.7% <33.33%> (+0.98%) ⬆️
torchvision/datasets/voc.py 23.07% <33.33%> (+0.97%) ⬆️
torchvision/datasets/celeba.py 19.73% <33.33%> (+1.66%) ⬆️
torchvision/datasets/sbd.py 33.33% <33.33%> (+2.08%) ⬆️
torchvision/datasets/stl10.py 27.77% <50%> (+0.6%) ⬆️
torchvision/datasets/utils.py 60.64% <68.42%> (+1.08%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9830d8...9b6008d. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks very good, thanks!

I'm approving it, but most of the TODOs (that I have confirmed) should go before merging.

Also, having tests for more datasets would make reviewing dataset PRs a lot easier!

torchvision/datasets/utils.py Outdated Show resolved Hide resolved
torchvision/datasets/voc.py Outdated Show resolved Hide resolved
torchvision/datasets/svhn.py Outdated Show resolved Hide resolved
torchvision/datasets/stl10.py Show resolved Hide resolved
torchvision/datasets/sbd.py Outdated Show resolved Hide resolved
torchvision/datasets/lsun.py Show resolved Hide resolved
torchvision/datasets/lsun.py Outdated Show resolved Hide resolved
torchvision/datasets/lsun.py Outdated Show resolved Hide resolved
torchvision/datasets/cityscapes.py Outdated Show resolved Hide resolved
@fmassa
Copy link
Member

fmassa commented Jul 25, 2019

Test failure is unrelated and test_randomresized_params seems flaky, I opened an issue in #1170

@pmeier pmeier changed the title [WIP] Standardize str argument verification in datasets Standardize str argument verification in datasets Jul 25, 2019
@pmeier
Copy link
Collaborator Author

pmeier commented Jul 25, 2019

Should be done now.

Also, having tests for more datasets would make reviewing dataset PRs a lot easier!

Agreed. If I find some time, I try to add some more.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 4886ccc into pytorch:master Jul 26, 2019
@pmeier pmeier deleted the verify_str_args branch July 26, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants