-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize str argument verification in datasets #1167
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
+ Coverage 65.11% 65.68% +0.56%
==========================================
Files 72 72
Lines 5619 5607 -12
Branches 867 857 -10
==========================================
+ Hits 3659 3683 +24
+ Misses 1699 1668 -31
+ Partials 261 256 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks very good, thanks!
I'm approving it, but most of the TODOs (that I have confirmed) should go before merging.
Also, having tests for more datasets would make reviewing dataset PRs a lot easier!
Test failure is unrelated and |
Should be done now.
Agreed. If I find some time, I try to add some more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
First steps towards #1132. I left some
TODO
s andFIXME
for review / discussion.