Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous dataset fixes #1174

Merged
merged 2 commits into from
Jul 26, 2019
Merged

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jul 26, 2019

Fixes some argument checking for the LSUN and STL10 dataset as discussed in #1167.

Philip Meier added 2 commits July 26, 2019 12:50
@pmeier pmeier changed the title Misc dataset fixes Miscellaneous dataset fixes Jul 26, 2019
@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #1174 into master will decrease coverage by 0.14%.
The diff coverage is 7.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
- Coverage   65.91%   65.76%   -0.15%     
==========================================
  Files          79       79              
  Lines        5809     5825      +16     
  Branches      882      883       +1     
==========================================
+ Hits         3829     3831       +2     
- Misses       1711     1725      +14     
  Partials      269      269
Impacted Files Coverage Δ
torchvision/datasets/lsun.py 22.91% <10%> (+0.44%) ⬆️
torchvision/datasets/stl10.py 26.26% <5.55%> (-1.52%) ⬇️
torchvision/transforms/transforms.py 80.94% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8102158...7774acb. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(but having tests would be even better!)

@fmassa fmassa merged commit 59c97d7 into pytorch:master Jul 26, 2019
@pmeier pmeier deleted the misc_dataset_fixes branch July 26, 2019 12:31
@pmeier
Copy link
Collaborator Author

pmeier commented Jul 26, 2019

(but having tests would be even better!)

I went for the low-hanging fruit first ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants