Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fix Windows CircleCI #1433

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Try fix Windows CircleCI #1433

merged 3 commits into from
Oct 16, 2019

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Oct 8, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

Merging #1433 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1433   +/-   ##
=======================================
  Coverage   64.46%   64.46%           
=======================================
  Files          83       83           
  Lines        6421     6421           
  Branches      982      982           
=======================================
  Hits         4139     4139           
  Misses       1992     1992           
  Partials      290      290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54b5977...2a8c4d9. Read the comment docs.

@peterjc123
Copy link
Contributor

@fmassa Do you know why when all the jobs fail when I push a commit here?

@fmassa
Copy link
Member Author

fmassa commented Oct 14, 2019

@peterjc123 looks like this is a problem with the rebase approach we are doing. Second try after #1427, but it still doesn't seem to be enough... :-/

Can you try reverting that PR here and try again?

@fmassa
Copy link
Member Author

fmassa commented Oct 15, 2019

@peterjc123 reverting those changes seemed to do the trick here, although it's a temporary solution.

I'm fixing the torchvision_linux_py3.7_cu100 failure in #1463

@fmassa fmassa force-pushed the try-fix-windows-ci branch from 9c44398 to 2a8c4d9 Compare October 16, 2019 19:03
@fmassa
Copy link
Member Author

fmassa commented Oct 16, 2019

Wohoo, CI is all green!

@fmassa fmassa merged commit 53b062c into pytorch:master Oct 16, 2019
@fmassa fmassa deleted the try-fix-windows-ci branch October 16, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants