Better handle corrupted videos #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
force-pushed
the
handle-corrupted-video-header
branch
from
c5acc9d to
1130fd1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1463 +/- ##
==========================================
+ Coverage 64.08% 64.14% +0.06%
==========================================
Files 80 80
Lines 6328 6342 +14
Branches 973 975 +2
==========================================
+ Hits 4055 4068 +13
Misses 1986 1986
- Partials 287 288 +1
Continue to review full report at Codecov.
|
|
Thanks for adding for exception handling logic. Hopefully the pyav video decoder is most robust. |
stephenyan1231
approved these changes
Oct 15, 2019
fmassa
added a commit
that referenced
this pull request
Oct 31, 2019
* Handle corrupted video headers in io * Catch exceptions while decoding partly-corrupted files * Add more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1271 and #1327
This PR adds a
try: exceptguards to the locations where we access the file. This should make it more robust to corrupted videos, as before we were only handling errors duringseek, and now he handle it both during container creation (i.e., if the header is corrupted, as in #1271) or when parts of the file are corrupted (as in #1327).cc @bjuncek @stephenyan1231