fixed test for windows by closing the created temporary files #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
pushed a commit
to fmassa/vision-1
that referenced
this pull request
Dec 18, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2019
Summary: Pull Request resolved: #1687 Reviewed By: cpuhrsch Differential Revision: D19157332 Pulled By: fmassa fbshipit-source-id: 7ab6deae603d6937ca688f745550dc158cfe3de3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we could not write on temporary files, these being already open
We now close the file, write on it and after using we delete them