Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed test for windows by closing the created temporary files (#1662) #1687

Closed
wants to merge 1 commit into from

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Dec 18, 2019

No description provided.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmassa has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #1687 into fbsync will decrease coverage by 65.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           fbsync   #1687       +/-   ##
==========================================
- Coverage   65.65%      0%   -65.66%     
==========================================
  Files          90      90               
  Lines        7085    7085               
  Branches     1075    1075               
==========================================
- Hits         4652       0     -4652     
- Misses       2126    7085     +4959     
+ Partials      307       0      -307
Impacted Files Coverage Δ
torchvision/models/quantization/__init__.py 0% <0%> (-100%) ⬇️
torchvision/ops/boxes.py 0% <0%> (-100%) ⬇️
torchvision/datasets/samplers/__init__.py 0% <0%> (-100%) ⬇️
torchvision/ops/_register_onnx_ops.py 0% <0%> (-100%) ⬇️
torchvision/models/__init__.py 0% <0%> (-100%) ⬇️
torchvision/models/segmentation/deeplabv3.py 0% <0%> (-100%) ⬇️
torchvision/io/__init__.py 0% <0%> (-100%) ⬇️
torchvision/models/segmentation/fcn.py 0% <0%> (-100%) ⬇️
torchvision/ops/__init__.py 0% <0%> (-100%) ⬇️
torchvision/models/segmentation/__init__.py 0% <0%> (-100%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0282cc0...1826bd4. Read the comment docs.

facebook-github-bot pushed a commit that referenced this pull request Dec 19, 2019
Summary: Pull Request resolved: #1687

Reviewed By: cpuhrsch

Differential Revision: D19157332

Pulled By: fmassa

fbshipit-source-id: 7ab6deae603d6937ca688f745550dc158cfe3de3
@fmassa fmassa closed this Dec 19, 2019
@fmassa fmassa deleted the import_1662 branch December 19, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants